-
Notifications
You must be signed in to change notification settings - Fork 39
chore(atomic): migrate atomic-automatic-facet to Lit #6576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦h folder Co-authored-by: alexprudhomme <[email protected]>
Co-authored-by: alexprudhomme <[email protected]>
Co-authored-by: alexprudhomme <[email protected]>
Co-authored-by: alexprudhomme <[email protected]>
BREAKING CHANGE: atomic-automatic-facet has been migrated from Stencil to Lit Co-authored-by: alexprudhomme <[email protected]>
Copilot
AI
changed the title
[WIP] Migrate atomic-automatic-facet to search folder
feat(atomic): migrate atomic-automatic-facet to Lit
Nov 19, 2025
Copilot finished work on behalf of
alexprudhomme
November 19, 2025 15:32
Contributor
|
@copilot Add straight forward minimalist golden path e2e tests. Thanks |
Co-authored-by: alexprudhomme <[email protected]>
Contributor
Author
Added minimalist golden path E2E tests in commit a163594. The tests cover:
Files created:
|
Copilot finished work on behalf of
alexprudhomme
November 19, 2025 16:28
fbeaudoincoveo
approved these changes
Nov 21, 2025
Contributor
fbeaudoincoveo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly have nothing to
packages/atomic/src/components/search/atomic-automatic-facet/atomic-automatic-facet.spec.ts
Outdated
Show resolved
Hide resolved
- Group clear-button and clear-button-icon tests under 'when values are selected' describe block - Remove duplicate 'should show clear button when values are selected' test (was duplicating shadow parts test) Co-authored-by: alexprudhomme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
.mdxfileindex.tsandlazy-index.tsfiles.https://coveord.atlassian.net/browse/KIT-[____]
fix #6413
Description
Migrates the
atomic-automatic-facetcomponent from Stencil to Lit. This component is a specialized facet generated by the automatic facets feature and is used internally byatomic-automatic-facet-generator.Changes Made
Component Migration
.tsx) to Lit (.ts) with Tailwind CSS stylingfacets/atomic-automatic-facet/to top-levelatomic-automatic-facet/directory in/searchfolder@/*path aliaseshtmltemplate literals and Lit directives (when,nothing)@customElement,@bindings(),@withTailwindStyles)Testing
buildFakeAutomaticFacettest fixtureDocumentation
.mdxfile documenting internal nature, shadow parts, and generator relationshipUpdated Files
index.tsandlazy-index.tsTesting
π¬ We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.