chore: fix dev mode #6622
Merged
chore: fix dev mode #6622
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexprudhomme
requested review from
fbeaudoincoveo,
lavoiesl and
louis-bompart
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Copilot finished reviewing on behalf of
alexprudhomme
November 21, 2025 19:52
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a dev mode infinite loop issue introduced when custom-element-tags.ts was added to the codebase. The file is auto-generated during build, causing it to be regenerated on every file change in dev mode, which triggers another build cycle.
- Adds
atomic-no-resultscomponent tag to the auto-generated custom element tags list - Excludes
custom-element-tags.tsfrom the dev mode file watcher to prevent infinite rebuild loops
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/atomic/src/utils/custom-element-tags.ts |
Adds atomic-no-results to the alphabetized list of custom element tags (auto-generated file) |
packages/atomic/scripts/dev.mjs |
Excludes custom-element-tags.ts from file watcher to prevent infinite build loops since this file is regenerated during builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexprudhomme
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
louis-bompart
approved these changes
Nov 24, 2025
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was broken by recent pr with the custom-element-tags.ts