Removed $.browser to support jQuery 1.9#41
Open
joshlangner wants to merge 5 commits intocowboy:masterfrom
Open
Removed $.browser to support jQuery 1.9#41joshlangner wants to merge 5 commits intocowboy:masterfrom
joshlangner wants to merge 5 commits intocowboy:masterfrom
Conversation
Allow jQuery 1.9 compatibility. $.browser also not needed since IE6/7/8 seem to be the only possible cases to not support it.
Allow jQuery 1.9 compatibility. $.browser also not needed since IE6/7/8 seem to be the only possible cases to not support it.
|
are you sure this is a valid fix? now the code is always run when |
|
Its only checking for IE that is missing, right, so how about changing that code to: (navigator.userAgent.match(/MSIE/i) !== null)? |
|
I sent a pull onto your fork, if you want to add that to this pull. |
Add the MSIE check back in (without dependency on $.browser)
|
What about IE9 and IE10? Will they handled properly? |
|
works with Firefox 58.0.2 (32-bit) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jQuery 1.9 removes $.browser. Some limited testing (IE 7-10, Safari 5, 6, Chrome 24, Firefox 18) suggests that this should be enough.