Skip to content

Lens deployment#10

Closed
squadgazzz wants to merge 1 commit intomainfrom
deployment/lens
Closed

Lens deployment#10
squadgazzz wants to merge 1 commit intomainfrom
deployment/lens

Conversation

@squadgazzz
Copy link
Contributor

This PR contains the Lens deployment info. There is no broadcast data since deployment with forge fails:

##### 232
❌  [Failed]Hash: 0xdf90191fb258e1f3cdd09cfdb11e8b0e8cbd39fb9db3e0810556550cb05bc809
Block: 3517090
Paid: 0.000428889193420541 ETH (154763 gas * 2.771264407 gwei)

Replaying the failed tx manually works fine. The contract is verified manually.

Copy link
Contributor

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cursed imho.
Because weiroll relies on DELEGATECALL for concrete uses, it can only be used in the context of the EVM Bytecode Interpreter and not on Lens generally, meaning that even assuming the encoding and execution works as expected (which I'm not saying) it would be incompatible with most of the currently existing network. If anything, there should be two weiroll deployments for this networks and a flurry of warnings and disclaimers everywhere about using this in Lens correctly.
I don't see any obvious EVM difference that critically applies to this contract, but weiroll is very low level and I don't feel confident enough to say it's going to work on Lens, not even in the confines of the EVM interpreter. So I wouldn't make this address official for Lens in any way.

@anxolin
Copy link

anxolin commented Jul 30, 2025

Maybe we don't need weiroll?

@alfetopito I assume bridge and swap and hooks won't be used in Lens, will they? If so, I don't think we need weiroll

@alfetopito
Copy link

Maybe we don't need weiroll?

@alfetopito I assume bridge and swap and hooks won't be used in Lens, will they? If so, I don't think we need weiroll

We stablished that weiroll was good for prototyping but not for production usage.
We should be able to get by without having it deployed on Lens.

@squadgazzz
Copy link
Contributor Author

Closing due to the comments above

@squadgazzz squadgazzz closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants