Conversation
fedgiac
left a comment
There was a problem hiding this comment.
This is cursed imho.
Because weiroll relies on DELEGATECALL for concrete uses, it can only be used in the context of the EVM Bytecode Interpreter and not on Lens generally, meaning that even assuming the encoding and execution works as expected (which I'm not saying) it would be incompatible with most of the currently existing network. If anything, there should be two weiroll deployments for this networks and a flurry of warnings and disclaimers everywhere about using this in Lens correctly.
I don't see any obvious EVM difference that critically applies to this contract, but weiroll is very low level and I don't feel confident enough to say it's going to work on Lens, not even in the confines of the EVM interpreter. So I wouldn't make this address official for Lens in any way.
|
Maybe we don't need weiroll? @alfetopito I assume bridge and swap and hooks won't be used in Lens, will they? If so, I don't think we need weiroll |
We stablished that weiroll was good for prototyping but not for production usage. |
|
Closing due to the comments above |
This PR contains the Lens deployment info. There is no broadcast data since deployment with forge fails:
Replaying the failed tx manually works fine. The contract is verified manually.