Skip to content

Align devcontainer configuration with readme #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fedgiac merged 1 commit into from
Jun 3, 2025
Merged

Align devcontainer configuration with readme #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
{
"name": "Foundry + Node",
"image": "mcr.microsoft.com/devcontainers/base:0",
"image": "mcr.microsoft.com/devcontainers/base:1",
"features": {
"ghcr.io/nlordell/features/foundry": {},
"ghcr.io/nlordell/features/foundry": {
Copy link

@anxolin anxolin Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's this using nicks's image? sholdn't this be pointing to one official repository or repo controlled by us?

Copy link
Contributor Author

@fedgiac fedgiac Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no official repo afaik. I agree we should change this at some point. We could either try to contact the Foundry team and ask if they are interested in supporting it or have an unofficial version under cowprotocol.

"version": "nightly-cb9dfae298fe0b5a5cdef2536955f50b8c7f0bf5"
},
"ghcr.io/devcontainers/features/node:1": {}
},
"customizations": {
"vscode" : {
"vscode": {
"extensions": [
"JuanBlanco.solidity"
]
Expand Down