dedicated storedFields executor experiment#225
Open
magibney wants to merge 2 commits intofs/branch_9_3from
Open
dedicated storedFields executor experiment#225magibney wants to merge 2 commits intofs/branch_9_3from
magibney wants to merge 2 commits intofs/branch_9_3from
Conversation
Collaborator
|
Just curious! For the threadlocal usage, is it something buried deep in the lucene end (was reading this PR)? And that it's triggered by Therefore your proposed change just invokes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very simple change (best viewed ignoring whitespace) that simply wraps the parts of the code that instantiate ThreadLocal storedFields and delegates them to a dedicated executor.
Consolidating in this way, and with an executor that allows its threads to die (at least for initial POC) should all but eliminate the "ThreadLocal storedFields cartesian product accumulation over time" problem, to hold us over until we have non-ThreadLocal storedFields in solr 9.7.
I determined these locations by analyzing GCP profiler (to identify code that in practice instantiates ThreadLocal storedFields).