Fallback to the default Balancer Vault address during the deployment#243
Merged
squadgazzz merged 2 commits intomainfrom Jun 12, 2025
Merged
Fallback to the default Balancer Vault address during the deployment#243squadgazzz merged 2 commits intomainfrom
squadgazzz merged 2 commits intomainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
carlos-cow
approved these changes
Jun 11, 2025
fedgiac
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the GPv2Settlement SC deployment script to default to the deterministic Balancer Vault address(
0xBA12222222228d8Ba445958a75a0704d566BF2C8) when it is not actually deployed yet.While the GPv2Settlement contract accepts a Balancer Vault address in its constructor, it does not strictly require the Vault to be deployed for basic ERC20 settlement functionality. This was confirmed in internal discussion:
Test Plan
Created an Avalanche fork on Tenderly before the Balancer Vault deployment, and the deployment worked well: https://dashboard.tenderly.co/cow-protocol/barn/testnet/14090eef-bc20-43fc-994d-2353743159cb
Potential risks
SAFE core contract addresses on ZK rollups differ from those on optimistic ones. Not sure if there is a chance that the Balancer Vault will be deployed later with a different address.