Adapt code to run more easily on other chains#125
Merged
Conversation
fhenneke
reviewed
Feb 14, 2025
fhenneke
reviewed
Feb 14, 2025
fhenneke
reviewed
Feb 14, 2025
fhenneke
approved these changes
Feb 14, 2025
Contributor
fhenneke
left a comment
fhenneke
left a comment
There was a problem hiding this comment.
The changes look correct.
I am assuming that some of the other tests will fail with these changes applied. Either they should be adapted as well (this PR) or they should be deleted (some other PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes some minimal changes so that the daemon can be deployed on all chains. Note that constants/thresholds have not been edited, so the current values only make sense for chains where the native token is ETH.