Skip to content

chore: update @cowprotocol/permit-utils #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cowdan merged 4 commits into from
May 28, 2025
Merged

chore: update @cowprotocol/permit-utils #943

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c18fdc
chore: update `@cowprotocol/permit-utils`
cowdan May 27, 2025
6bf2ff2
chore: fix `recheckPermitInfo` yarn task
cowdan May 28, 2025
ef9b8b3
chore: remove `AVAX` from `CowSwap.json` and images
cowdan May 28, 2025
cac4d57
chore: remove `POL` from `CowSwap.json`
cowdan May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"license": "(MIT OR Apache-2.0)",
"dependencies": {
"@cowprotocol/cow-sdk": "^5.11.0-RC.0",
"@cowprotocol/permit-utils": "^0.4.0",
"@cowprotocol/permit-utils": "^0.7.0-RC.0",
Copy link
Contributor

@coderabbitai coderabbitai bot May 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify integration of the new RC release

You’ve upgraded @cowprotocol/permit-utils to ^0.7.0-RC.0. Please ensure that:

  1. Any breaking changes in the RC are handled in your code (check the library’s CHANGELOG or migration guide).
  2. All import sites and API calls still compile and behave as expected.
  3. Your lockfile (yarn.lock or package-lock.json) has been updated and committed alongside this bump.

Run this script to confirm lockfile updates and locate all import sites for manual review:

🏁 Script executed:

#!/bin/bash
# 1) Check for updated lockfile
if ! git diff --name-only | grep -E 'yarn.lock|package-lock.json'; then
  echo "ERROR: No lockfile changes detected—please run npm/yarn install and commit the lockfile."
  exit 1
fi

# 2) List all references to permit-utils for API validation
rg -n "@cowprotocol/permit-utils" --glob "src/**/*"

Length of output: 258

Action Required: Commit Updated Lockfile & Verify API Usage

The RC bump for @cowprotocol/permit-utils was applied in package.json but no lockfile changes were detected. Please address the following before merging:

• package.json (line 44): You’ve upgraded to ^0.7.0-RC.0.
– Review the library’s CHANGELOG or migration guide for any breaking changes.
• Lockfile: Run npm install or yarn install and commit the resulting package-lock.json or yarn.lock.
• Import sites & API calls: Locate all references and confirm compatibility by running:

rg -n "@cowprotocol/permit-utils" --glob "src/**/*"
🤖 Prompt for AI Agents 
In package.json at line 44, you have upgraded @cowprotocol/permit-utils to
^0.7.0-RC.0 but have not updated the lockfile. To fix this, run npm install or
yarn install to update the lockfile (package-lock.json or yarn.lock), then
commit the updated lockfile alongside this package.json change. Additionally,
review the library’s CHANGELOG or migration guide for any breaking changes and
verify all import sites and API calls referencing @cowprotocol/permit-utils
still compile and behave correctly.

Copy link
Contributor Author

@cowdan cowdan May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of the files of this PR is literally yarn.lock!

Copy link
Contributor

@coderabbitai coderabbitai bot May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check what files are changed in this PR
git diff --name-only HEAD~1 HEAD
echo "---"
# Also check if yarn.lock exists and was modified
git diff --stat HEAD~1 HEAD

Length of output: 453

🏁 Script executed:

#!/bin/bash
# Check what files are in the repository and look for yarn.lock
ls -la | grep -E "(yarn.lock|package-lock.json)"
echo "---"
# Check git status to see what files exist
git status --porcelain
echo "---"
# List all files that might be related to this PR
fd -t f yarn.lock
fd -t f package-lock.json
echo "---"
# Check if there are any recent commits and what files they modified
git log --oneline -5

Length of output: 239

🏁 Script executed:

#!/bin/bash
# Check if yarn.lock contains the updated permit-utils version
grep -A 2 -B 2 "@cowprotocol/permit-utils" yarn.lock
echo "---"
# Check the last modification time and see recent git activity
stat yarn.lock
echo "---"
# See if we can get any info about recent changes to yarn.lock
git log --oneline -3 --follow yarn.lock

Length of output: 543

@cowdan You're absolutely right, and I apologize for the error! 🤦‍♀️

I can now see that yarn.lock is indeed present and contains the updated @cowprotocol/permit-utils@^0.7.0-RC.0 entry:

"@cowprotocol/permit-utils@^0.7.0-RC.0":
  version "0.7.0-RC.0"
  resolved "https://registry.yarnpkg.com/@cowprotocol/permit-utils/-/permit-utils-0.7.0-RC.0.tgz#a7efce813b68b4d1d2d937ef8a0de21a93901bb5"
  integrity sha512-qbJ9RFO65M2UYodKojlxv4jAclUFqLprmwR5sZZwd3eHSUQ4Nc6sJ6yK5uj1KfMOOz0C1dgqnfBYRwHzYAXIGw==

My initial script failed to detect the changes properly. Thank you for the correction! The lockfile has been properly updated alongside the package.json change, so that aspect of the upgrade is handled correctly.

The only remaining consideration would be to verify that any breaking changes in the RC version are compatible with your existing code, but the dependency management side is properly taken care of.

"@uniswap/token-lists": "^1.0.0-beta.33",
"ajv": "^8.12.0",
"ajv-cli": "^5.0.0",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@
graphql-request "^4.3.0"
limiter "^3.0.0"

"@cowprotocol/permit-utils@^0.4.0":
version "0.4.0"
resolved "https://registry.yarnpkg.com/@cowprotocol/permit-utils/-/permit-utils-0.4.0.tgz#36f19a1a6ea813ebf583d226e34d8abb203f8472"
integrity sha512-iWbxk9m2JGgx4gtQ/F0iNoFKOcBSVnRwYQKgtVZy5gkpVxNXhFd/YRZoLYFpxL7N4OLMug/PG6Y5whmZkytu5w==
"@cowprotocol/permit-utils@^0.7.0-RC.0":
version "0.7.0-RC.0"
resolved "https://registry.yarnpkg.com/@cowprotocol/permit-utils/-/permit-utils-0.7.0-RC.0.tgz#a7efce813b68b4d1d2d937ef8a0de21a93901bb5"
integrity sha512-qbJ9RFO65M2UYodKojlxv4jAclUFqLprmwR5sZZwd3eHSUQ4Nc6sJ6yK5uj1KfMOOz0C1dgqnfBYRwHzYAXIGw==
dependencies:
"@1inch/permit-signed-approvals-utils" "^1.4.10"
"@cowprotocol/app-data" "^1.1.0"
Expand Down