Conversation
WalkthroughThis update removes the Polygon native token (address 0x0000000000000000000000000000000000001010) from relevant token lists and introduces an override to exclude it from processing. The build script is updated to use "tsx" instead of "ts-node", with corresponding dependency adjustments. Minor refactoring of import order and type definitions is included. Changes
Sequence Diagram(s)sequenceDiagram
participant Script as Build Script
participant TokenList as Token List Processor
participant Overrides as Override Config
participant Output as Output List
Script->>TokenList: Run processTokenList()
TokenList->>Overrides: Check for token overrides
Overrides-->>TokenList: Return override (may be null)
TokenList->>TokenList: If override is null, exclude token
TokenList->>Output: Write filtered token list
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
package.json (1)
38-38: Clarifytsxinvocation for future flagsUsing bare
tsxdepends on Yarn forwarding the remaining CLI args (the script path) verbatim.
If you later need Node flags (--inspect,--no-warnings, etc.) or a specifictsconfig, you’ll have to modify this again.
Consider making the full CLI explicit now to avoid follow-up edits.src/scripts/auxLists/index.ts (1)
13-13: Guard against case-mismatch when looking up overrides
processTokenListlower–cases the address before doing the lookup (overrides[token.address.toLowerCase()]).
Here you store the address literal already in lower-case, which is correct, but it’s easy to accidentally paste a checksummed / mixed-case address next time and silently miss the override.Consider forcing the key to lower-case at assignment time as well:
-OVERRIDES[SupportedChainId.POLYGON]['0x0000000000000000000000000000000000001010'] = null +OVERRIDES[SupportedChainId.POLYGON]['0x0000000000000000000000000000000000001010'.toLowerCase()] = nullNot a blocker, but it hardens the pattern against future copy-paste errors.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (6)
package.json(2 hunks)src/public/CoinGecko.137.json(1 hunks)src/public/Uniswap.137.json(1 hunks)src/scripts/auxLists/index.ts(1 hunks)src/scripts/auxLists/processTokenList.ts(2 hunks)src/scripts/auxLists/utils.ts(2 hunks)
🔇 Additional comments (5)
package.json (1)
62-63: Ensuretsxis present in all environments
tsxmoved todevDependencies, yet everyyarn run-script …relies on it at runtime.
If any CI/CD job installs production dependencies only (yarn --production/npm ci --only=production), these scripts will break.Either:
- Guarantee devDeps are always installed, or
- Promote
tsxto regulardependencies.src/scripts/auxLists/utils.ts (2)
1-1: Import re-ordering LGTMMoving the
@cowprotocol/cow-sdkimport to the top improves consistency; no functional impact.
16-17: ```shell
#!/bin/bashDisplay the mapping logic in processTokenList to inspect override handling
sed -n '120,190p' src/scripts/auxLists/processTokenList.ts
</details> <details> <summary>src/public/CoinGecko.137.json (1)</summary> `8-8`: **Version bump: sync across Polygon (137) lists.** The major version was incremented to 29 here; please verify that Uniswap.137.json and any other Polygon chain-137 lists have their version numbers updated in lockstep to prevent downstream mismatches. </details> <details> <summary>src/public/Uniswap.137.json (1)</summary> `8-9`: **Version bump aligns with semver rules – looks good** A major version increment (`0.x → 1.0`) is appropriate after removing the native POL token entry. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
3 participants
Summary
POL is duplicated currently because it's being added to Uniswap and Coingecko generated token lists.
This change:
0x0000000000000000000000000000000000001010from being added to Polygon listsTesting
Ran the script locally
Summary by CodeRabbit