Merged
Conversation
micheloosterhof
force-pushed
the
claude/c17-c23-comparison-UEqFB
branch
from
b1e6091 to
94a611a
Compare
…rt %-formatting to f-strings
- Replace `from typing import Pattern` with `re.Pattern` (breaks on Python 3.12+)
- Replace `from typing import TextIO` with `from io import TextIO`
- Remove redundant `(object)` base class from 5 test classes
- Convert ~280 %-format string expressions to f-strings across 46 files
- Convert .format() calls to f-strings where straightforward
- Leave logger lazy formatting (`logger.debug("msg %s", val)`) unchanged
- Leave commented-out code and SQL placeholders unchanged
micheloosterhof
force-pushed
the
claude/c17-c23-comparison-UEqFB
branch
from
94a611a to
8966011
Compare
micheloosterhof
changed the title
GCC 14 (Debian 13/trixie) treats -Wreturn-mismatch as an error, causing the build to fail on `return;` in a function returning bool. https://claude.ai/code/session_01WgDVPPHs8rdi1sewh2So5z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo Python % format strings
Remove old python constructs