Open
Conversation
Use vmactions to run FreeBSD and OpenBSD in VMs for build testing. Both run in parallel with the existing Linux build.
- Add cmake/FindReadline.cmake for proper readline detection on all platforms - Make libdl conditional (BSD has dlopen in libc) - Add config.passthrough for simple localhost proxy configuration - Add passthrough integration test with Docker-based CI workflow The passthrough config proxies all TCP/UDP to localhost services, responds to ICMP, and presents a Cisco switch OS fingerprint.
- Add __BSD_VISIBLE for FreeBSD to expose u_int type in pcap headers - Change passthrough config to proxy only specific ports (22, 80, 443, 53) instead of all ports, so unconfigured ports appear closed - Update test to verify both proxy functionality and closed ports
- Add /usr/local/lib and /usr/local/include to libevent search paths - Add link_directories for library directory to fix linker issues - Add libpcap to OpenBSD package list
OpenBSD has old libevent 1.x in /usr/lib but we need libevent2 from /usr/local/lib (installed via pkg_add). Use NO_DEFAULT_PATH to check our hints first before falling back to system paths.
- Remove PCRE dependency entirely, use standard POSIX regex.h - proxy.c now uses regcomp/regexec/regfree instead of pcre_* - Remove PCRE from CMakeLists.txt - proxy/smtp always build now - Remove pcre from OpenBSD package list in CI This eliminates an external dependency for simple regex matching.
On OpenBSD (and some other systems), libevent2 is split into two libraries: libevent_core and libevent_extra. The evtag_* RPC functions (evtag_marshal, evtag_marshal_timeval, etc.) are in libevent_extra. - Detect both libevent_core and libevent_extra libraries - Combine them into LIBEVENT_LIBRARIES variable - Update all target_link_libraries to use LIBEVENT_LIBRARIES
On OpenBSD, /usr/include/event.h is the old libevent1 header while libevent2 headers are in /usr/local/include. The evtimer_new and evsignal_new macros only exist in libevent2 headers. - Add NO_DEFAULT_PATH to find_path for include directory - Use include_directories(BEFORE ...) to ensure libevent2 headers take precedence over any system headers
dentworkspdrllc-coder
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan