Skip to content

Conversation

@n1n-api
Copy link

@n1n-api n1n-api commented Jan 17, 2026

This PR adds n1n.ai as a model provider.

Changes:

  • Added N1N to ModelClass enum in Thrift and Go.
  • Registered n1n provider in mode_provider.go.
  • Registered n1n model builder (using OpenAI compatibility) in model_builder.go.
  • Added model_template_n1n.yaml.

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2026

CLA assistant check
All committers have signed the CLA.

@fanlv
Copy link
Collaborator

fanlv commented Jan 17, 2026

Have you tested adding n1n.ai models through the management page?

@fanlv
Copy link
Collaborator

fanlv commented Jan 17, 2026

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

n1n seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLA 也签一下。

@n1n-api
Copy link
Author

n1n-api commented Jan 17, 2026

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
n1n seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLA 也签一下。

已经签好了~

@n1n-api
Copy link
Author

n1n-api commented Jan 17, 2026

Have you tested adding n1n.ai models through the management page?

Yea..we have customers tested on that :)

@fanlv fanlv closed this Jan 17, 2026
@fanlv fanlv reopened this Jan 17, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
backend/bizpkg/config/modelmgr/mode_provider.go 0.00% 11 Missing ⚠️
...ckend/api/model/app/developer_api/developer_api.go 0.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
backend/bizpkg/llm/modelbuilder/model_builder.go 0.00% <ø> (ø)
...ckend/api/model/app/developer_api/developer_api.go 0.08% <0.00%> (-0.01%) ⬇️
backend/bizpkg/config/modelmgr/mode_provider.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fanlv fanlv closed this Jan 17, 2026
@fanlv fanlv reopened this Jan 17, 2026
Copy link
Collaborator

@fanlv fanlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default_icon/n1n.png 这个文件没有上传

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件夹下面的 模版没用了,现在都是通过管理后台 动态去添加 模型了。不用加这个文件。

@fanlv
Copy link
Collaborator

fanlv commented Jan 17, 2026

license/cla 状态检查也有点问题,一直 waiting,可能要周一找其他同学看下。

@n1n-api
Copy link
Author

n1n-api commented Jan 17, 2026

default_icon/n1n.png 这个文件没有上传

apple-touch-icon 谢谢!我把图片也传到附件了,是不是需要重新提交一下...

@n1n-api
Copy link
Author

n1n-api commented Jan 17, 2026

license/cla 状态检查也有点问题,一直 waiting,可能要周一找其他同学看下。

辛苦麻烦您了~

@fanlv fanlv closed this Jan 19, 2026
@fanlv fanlv reopened this Jan 19, 2026
@fanlv
Copy link
Collaborator

fanlv commented Jan 19, 2026

你代码提交的邮箱和 n1n-api 这个账号的邮箱一直吗?你check 一下吧。 还有comment 的图片 default_icon/n1n.png 还没有提交。

**n1n-api **

@n1n-api n1n-api force-pushed the feat/add-n1n-provider branch from 4f1df9f to 55bb955 Compare January 19, 2026 09:29
@n1n-api
Copy link
Author

n1n-api commented Jan 19, 2026

你代码提交的邮箱和 n1n-api 这个账号的邮箱一直吗?你check 一下吧。 还有comment 的图片 default_icon/n1n.png 还没有提交。

**n1n-api **

感谢您的审核。

我已经根据反馈更新了分支:

  1. 修正了提交的邮箱
  2. 在 docker/volumes/minio/default_icon/ 目录下添加了 n1n.png 图标

请帮忙再看下,谢谢!

@fanlv
Copy link
Collaborator

fanlv commented Jan 19, 2026

可以提供一下”通过管理后台添加 N1N 模型“ 成功的测试截图吗。

@n1n-api
Copy link
Author

n1n-api commented Jan 19, 2026

可以提供一下”通过管理后台添加 N1N 模型“ 成功的测试截图吗。

您好,请查看附件~

Screenshot 2026-01-20 at 2 25 55 AM

@fanlv
Copy link
Collaborator

fanlv commented Jan 20, 2026

如果只是通过 openAI 协议添加的话,现有的能力就支持。你加的功能用不上。

@n1n-api
Copy link
Author

n1n-api commented Jan 20, 2026

如果只是通过 openAI 协议添加的话,现有的能力就支持。你加的功能用不上。

不是要从你们的动态管理那里添加吗?以为要看一下是否接口本身能连接通🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants