Skip to content

hotfix(memory.database): order error where db query with field id #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baiyutang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

hotfix(memory.database): order error where db query with field id #2603

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c203249
hotfix(memory.database): order error where db query with field id
baiyutang Feb 2, 2026
294f57d
docs
baiyutang Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions backend/domain/memory/database/service/database_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,11 @@ func (d databaseService) executeSelectSQL(ctx context.Context, req *ExecuteSQLRe
physicalField := order.Field
if mapped, exists := fieldNameToPhysical[order.Field]; exists {
physicalField = mapped
} else {
// AlterID
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment "AlterID" is vague and doesn't clearly explain the purpose of this else clause. Consider a more descriptive comment such as "Check if order.Field is a field ID (AlterID as string) instead of a field name" to clarify that this handles the case where the field is identified by its ID rather than its name.

Suggested change
// AlterID
// Check if order.Field is a field ID (AlterID as string) instead of a field name

Copilot uses AI. Check for mistakes.
if _, exists := fieldMap[order.Field]; exists {
physicalField = fieldMap[order.Field].PhysicalName
}
}

orderBy = append(orderBy, &rdb.OrderBy{
Expand Down
Loading