feat: Integrate controller into shell #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/shell
ecnivtwelve
changed the title
ecnivtwelve
changed the title
ecnivtwelve
changed the title
Crash--
reviewed
Dec 1, 2025
| .where({ 'metadata.externalId': externalId }) | ||
| .indexFields(['metadata.externalId']) | ||
| .limitBy(1), | ||
| { as: `io.cozy.files/${externalId}` } |
There was a problem hiding this comment.
see https://github.com/cozy/cozy-guidelines?tab=readme-ov-file#naming-of-queries
because here, you named like getById so we'll share wrong cache (because cache is based on the as attributes)
| const path = currentlyOpenedFile | ||
| ? currentlyOpenedFile.path.replace(currentlyOpenedFile.name, '') | ||
| : '' | ||
| const sanitizedPath = path.endsWith('/') ? path.slice(0, -1) : path |
There was a problem hiding this comment.
pretty sure you have all you want in cozy-client. Either is models/file or Filecollection I don't know
| controllerApp.current.contentWindow.postMessage( | ||
| 'selectedFile:' + currentlyOpenedFile.id, | ||
| '*' | ||
| ) |
There was a problem hiding this comment.
Why you don't use cozy bridge for that? You should talk to @zatteo
| if (e.data === 'loaded') { | ||
| if (!controllerHasLoaded) { | ||
| setControllerHasLoaded(true) | ||
| } |
| id="controllerApp" | ||
| src={controllerAppUrl} | ||
| ></iframe> | ||
| )} |
There was a problem hiding this comment.
At the end, maybe it should be the bridge itself that render the iframe. Like that no need to create iframe on every container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows LaSuite Docs to run in a shell environment with a container app installed.
Known issues
Required flags
docs.embedded-app-urlhttps://docs.example.comRequired deployments
Changes