fix(lookup): initialize map to prevent nil map assignment panic

[kvaps]

Summary

Fix panic "assignment to entry in nil map" when lookup function processes resources with empty or malformed metadata.

Fixes #95

Problem

In extractResourceData, the res variable was declared as:

var res map[string]interface{}

This creates a nil map. If yaml.Unmarshal doesn't populate it (e.g., due to empty or malformed metadata), the subsequent line res["spec"] = unmarshalledData panics.

Solution

Initialize the map explicitly:

res := make(map[string]interface{})

This ensures the map is never nil, preventing the panic.

[coderabbitai]

Warning

Rate limit exceeded

@kvaps has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 59d3d43 and 9fb2a86.

📒 Files selected for processing (1)

• pkg/engine/engine.go

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @kvaps, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical runtime panic within the lookup function. The issue stemmed from an uninitialized map being assigned values, which would occur when processing resource metadata that was either empty or malformed. By ensuring the map is always properly initialized, the change enhances the robustness of resource data extraction and prevents application crashes.

Highlights

• Panic Fix: Addresses a panic 'assignment to entry in nil map' that occurred when the lookup function processed resources with empty or malformed metadata.
• Root Cause: The panic was caused by a nil map variable res not being properly initialized before an assignment, specifically when yaml.Unmarshal failed to populate it.
• Solution: The fix explicitly initializes the map using res := make(map[string]interface{}), ensuring it is never nil and preventing the panic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a panic by initializing a map. The change is valid and addresses the immediate issue. I've also added a suggestion to handle several ignored errors in the same function to improve its robustness and prevent potential silent failures.

[lexfrei]

Good improvement — adding error handling where errors were previously ignored is the right call.

However, there's a gap: errors from extractResourceData are detected but silently swallowed:

res, err := extractResourceData(r)
if err != nil {
    return nil  // error is lost
}

This is inconsistent with how callError is handled above (line 609), where it's appended to multiErr.

Suggested fix:

res, err := extractResourceData(r)
if err != nil {
    multiErr = multierror.Append(multiErr, err)
    return nil
}

Also consider including resource type/ID in error messages for easier debugging.