Merged
Conversation
Member
|
Do we need a patch release? |
Contributor
Author
|
Yes. I am afraid we need a patch release otherwise cp2k won't build with hip without this line. I should have spotted it earlier. |
Contributor
Author
|
I confirm the patch is needed to build cp2k with or without spack. |
Member
|
No problem, doing it tonight. Thanks for the contribution! |
Contributor
|
@mtaillefumier , thank you for catching that. I should not have missed this file in my update earlier this year. Also learned a lesson that I should try building CP2K too in order to test DBCSR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix providing hiprtc target when
find_package(DBCSR)is called