Fix: improve output location

Author: cpa-coder

DebitExpress.VatRelief/MainWindow.xaml

@@ -7,7 +7,6 @@
     xmlns:ctrl="http://debitexpress.com/winfx/xaml/controls"
     xmlns:attached="http://debitexpress.com/winfx/xaml/attached-properties"
     xmlns:materialDesign="http://materialdesigninxaml.net/winfx/xaml/themes"
-    xmlns:dialogs="http://debitexpress.com/winfx/xaml/dialogs"
     mc:Ignorable="d"
     ResizeMode="NoResize"
     Title="DebitExpress VAT Relief"

DebitExpress.VatRelief/MainWindow.xaml.cs

@@ -1,6 +1,8 @@
 using System;
+using System.Diagnostics;
 using System.IO;
 using System.Linq;
+using System.Reflection;
 using System.Windows;
 using DebitExpress.VatRelief.Models;
 using DebitExpress.VatRelief.Utils;
@@ -93,9 +95,9 @@ private async void OnGenerate(object sender, RoutedEventArgs e)
                 return;
             }
 
-            const string loc = @"%USERPROFILE%\Desktop";
-            var path = Environment.ExpandEnvironmentVariables(loc);
             ExcelData data = result;
+            var path = Path.Combine(Path.GetTempPath(), "vat-relief", Guid.NewGuid().ToString().Replace("-", string.Empty));
+            Directory.CreateDirectory(path);
 
             var generator = new DatFileGenerator();
             var generateResult = await generator.GenerateAsync(data, path);
@@ -108,17 +110,34 @@ private async void OnGenerate(object sender, RoutedEventArgs e)
             var reconWriter = new ExcelReconWriter();
             var writeResult = reconWriter.WriteReconciliationReport(data, path);
 
-            if (writeResult.IsSuccess)
-                NotifyResult("Files generated successfully");
-            else
+            if (writeResult.IsFaulted)
+            {
                 NotifyErrorResult(writeResult.ToString());
+                return;
+            }
+
+            NotifyResult("Files generated successfully");
+            OpenFolder(path);
         }
         finally
         {
             GenerateButton.IsEnabled = true;
         }
     }
 
+    private void OpenFolder(string path)
+    {
+        if (!Directory.Exists(path)) return;
+
+        var startInfo = new ProcessStartInfo
+        {
+            Arguments = path,
+            FileName = "explorer.exe"
+        };
+
+        Process.Start(startInfo);
+    }
+
     private void NotifyErrorResult(string message)
     {
         _messageQueue.Clear();

DebitExpress.VatRelief/Utils/DatFileGenerator.cs

@@ -56,7 +56,7 @@ public async Task<Result> GenerateAsync(ExcelData data, string path)
 
     private async Task GenerateSalesAsync(Info info, DateTime month, IReadOnlyCollection<Sales> items, string path)
     {
-        var datFileFolder = Path.Combine(path, "DAT FILES");
+        var datFileFolder = Path.Combine(path, "DAT Files");
         Directory.CreateDirectory(datFileFolder);
 
         var fileName = $"{info.Tin}S{month:MM}{month:yyyy}.DAT";

DebitExpress.VatRelief/Utils/ExcelReconWriter.cs

@@ -13,11 +13,10 @@ public Result WriteReconciliationReport(ExcelData data, string path)
     {
         try
         {
-            var fileFolder = Path.Combine(path, "EXCEL");
-            Directory.CreateDirectory(fileFolder);
+            Directory.CreateDirectory(path);
 
             var fileName = $"{Extensions.QuarterRangeString(data.Info.Month, data.Info.Year)}.xlsx";
-            var fullPath = Path.Combine(fileFolder, fileName);
+            var fullPath = Path.Combine(path, fileName);
 
             var workbook = new XLWorkbook();
             var salesSheet = workbook.Worksheets.Add("SALES");