Skip to content

Commit f6cb475

Browse files
committed
Fix: update taxpayer's full name when empty
1 parent 4255925 commit f6cb475

File tree

4 files changed

+29
-4
lines changed

4 files changed

+29
-4
lines changed

DebitExpress.VatRelief/DebitExpress.VatRelief.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
<PackageReference Include="DebitExpress.Controls" Version="2.1.24" />
2323
<PackageReference Include="DebitExpress.DialogService" Version="2.1.8" />
2424
<PackageReference Include="DebitExpress.Extensions" Version="1.0.11" />
25+
<PackageReference Include="DebitExpress.StringBuilders" Version="1.0.5" />
2526
</ItemGroup>
2627

2728
<ItemGroup>

DebitExpress.VatRelief/Models/Purchases.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using DebitExpress.StringBuilders;
23

34
namespace DebitExpress.VatRelief.Models;
45

@@ -15,7 +16,11 @@ public struct Purchases
1516

1617
public string MiddleName { get; set; }
1718

18-
public string FullName => $"{LastName}, {FirstName} {MiddleName}";
19+
public string FullName => new NameBuilder()
20+
.LastName(LastName)
21+
.WithFirstName(FirstName)
22+
.WithMiddleName(MiddleName)
23+
.ToString() ?? string.Empty;
1924
public string Street { get; set; }
2025

2126
public string City { get; set; }

DebitExpress.VatRelief/Models/Sales.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using DebitExpress.StringBuilders;
23

34
namespace DebitExpress.VatRelief.Models;
45

@@ -10,7 +11,12 @@ public struct Sales
1011
public string LastName { get; set; }
1112
public string FirstName { get; set; }
1213
public string MiddleName { get; set; }
13-
public string FullName => $"{LastName}, {FirstName} {MiddleName}";
14+
15+
public string FullName => new NameBuilder()
16+
.LastName(LastName)
17+
.WithFirstName(FirstName)
18+
.WithMiddleName(MiddleName)
19+
.ToString() ?? string.Empty;
1420
public string Street { get; set; }
1521
public string City { get; set; }
1622
public decimal Exempt { get; set; }

DebitExpress.VatRelief/Utils/ExcelReconWriter.cs

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
using System.IO;
44
using System.Linq;
55
using ClosedXML.Excel;
6+
using DebitExpress.StringBuilders;
67
using DebitExpress.VatRelief.Models;
78

89
namespace DebitExpress.VatRelief.Utils;
@@ -101,7 +102,13 @@ private void WriteSalesData(IXLWorksheet sheet, Info info, List<Sales> sales)
101102
sheet.Cell("A2").Value = "RECONCILIATION OF LISTING FOR ENFORCEMENT";
102103
sheet.Cell("A6").Value = $"TIN : {info.Tin.Strip()}";
103104

104-
var name = info.NonIndividual ? info.RegName : $"{info.LastName}, {info.FirstName} {info.MiddleName}";
105+
var taxPayer = new NameBuilder()
106+
.LastName(info.LastName)
107+
.WithFirstName(info.FirstName)
108+
.WithMiddleName(info.MiddleName)
109+
.ToString();
110+
111+
var name = info.NonIndividual ? info.RegName : taxPayer;
105112
sheet.Cell("A7").Value = $"OWNER'S NAME: {name}";
106113

107114
sheet.Cell("A8").Value = $"OWNER'S TRADE NAME : {info.TradeName}";
@@ -195,7 +202,13 @@ private void WritePurchasesData(IXLWorksheet sheet, Info info, List<Purchases> p
195202
sheet.Cell("A2").Value = "RECONCILIATION OF LISTING FOR ENFORCEMENT";
196203
sheet.Cell("A6").Value = $"TIN : {info.Tin.Strip()}";
197204

198-
var name = info.NonIndividual ? info.RegName : $"{info.LastName}, {info.FirstName} {info.MiddleName}";
205+
var taxPayer = new NameBuilder()
206+
.LastName(info.LastName)
207+
.WithFirstName(info.FirstName)
208+
.WithMiddleName(info.MiddleName)
209+
.ToString();
210+
211+
var name = info.NonIndividual ? info.RegName : taxPayer;
199212
sheet.Cell("A7").Value = $"OWNER'S NAME: {name}";
200213

201214
sheet.Cell("A8").Value = $"OWNER'S TRADE NAME : {info.TradeName}";

0 commit comments

Comments
 (0)