fix: suppress Subroutine redefined warnings in test suite#50
Merged
toddr merged 1 commit intocpan-authors:mainfrom Mar 18, 2026
Merged
fix: suppress Subroutine redefined warnings in test suite#50toddr merged 1 commit intocpan-authors:mainfrom
toddr merged 1 commit intocpan-authors:mainfrom
Conversation
MockJabberClient.pm declares package Net::Jabber::Client then loads Net::Jabber (which defines the real RosterDB and RosterRequest subs). When the mock re-declares these stubs, Perl emits redefinition warnings. Add 'no warnings "redefine"' before the intentional overrides. Fixes cpan-authors#48 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
toddr
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MockJabberClient.pm declares
package Net::Jabber::Clientthenuse Net::Jabber, which loads the real module'sRosterDBandRosterRequestsubs. When the mock re-declares these stubs, Perl emits "Subroutine redefined" warnings on every test file that uses the mock.Added
no warnings 'redefine'before the intentional stub overrides.Fixes #48
Changes
no warnings 'redefine'int/lib/MockJabberClient.pmbeforeRosterDBandRosterRequeststub definitionsTest plan
make testpasses with no "Subroutine redefined" warnings in outputGenerated by Kōan /fix
Quality Report
Changes: 1 file changed, 2 insertions(+)
Code scan: clean
Tests: failed (timeout (120s))
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline