Skip to content

Dist landing page #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Dist landing page #33

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92ce577
commit so you can see?
May 23, 2025
81159f0
new template file dist/search.html.ep
May 23, 2025
0662141
dist landing page
May 23, 2025
a743e1d
remove debugging
May 23, 2025
3d38af6
allow partial searches on dist page
May 24, 2025
d7d753f
add validation to the search input only allow a-zA-Z0-9\- characters
May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions share/templates/dist/search.html.ep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@
self.poll(res.dists, input.value, 0);
});
});

input.addEventListener('keyup', function () {
input.value = input.value.replace(new RegExp("([^a-zA-Z0-9\-]+)", "g"), "");
Copy link
Member

@preaction preaction Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do this without JavaScript if you'd like by using the <input pattern="..." /> HTML attribute (MDN docs). If the input doesn't pass validation, the submit event shouldn't(?) happen.

Copy link
Author

@ThisUsedToBeAnEmail ThisUsedToBeAnEmail Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a preference, I prefer validating the input and preventing the characters this way.

});
},
switchSearchMode: function (type) {
let self = this;
Expand Down