refactor: [M3-9214] - Introduce the (at)linode/shared package (linode#11844)

* Create new linode/shared package

* Fix imports

* Appease typescript

* Update imports

* Move nodebalancer factory

* Test fixes

* Update package scripts

* Added changeset: Move `LinodeSelect` to new `shared` package

* Added changeset: New `shared` package with `LinodeSelect` as the first component

* Linting fixes

* Add shared package to storybook

* Add missing dependencies

* Update lockfile

* Feedback @bnussman-akamai @coliu-akamai

* Fix unit test

* Add validation artifact to ci.yml

* Fix cannabalizing imports

* Use <CloseIcon /> in LinodeSelect

Author: hkhalil-akamai

.github/workflows/ci.yml

@@ -17,6 +17,7 @@ jobs:
             "linode-manager",
             "@linode/api-v4",
             "@linode/queries",
+            "@linode/shared",
             "@linode/ui",
             "@linode/utilities",
             "@linode/validation",
@@ -233,6 +234,30 @@ jobs:
       - run: pnpm install --frozen-lockfile
       - run: pnpm run --filter @linode/queries test
 
+  test-shared:
+    runs-on: ubuntu-latest
+    needs: build-sdk
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
+        with:
+          run_install: false
+          version: 10
+      - uses: actions/setup-node@v4
+        with:
+          node-version: "20.17"
+          cache: "pnpm"
+      - uses: actions/download-artifact@v4
+        with:
+          name: packages-api-v4-lib
+          path: packages/api-v4/lib
+      - uses: actions/download-artifact@v4
+        with:
+          name: packages-validation-lib
+          path: packages/validation/lib
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm run --filter @linode/shared test
+
   typecheck-ui:
     runs-on: ubuntu-latest
     needs: build-sdk
@@ -289,6 +314,30 @@ jobs:
       - run: pnpm install --frozen-lockfile
       - run: pnpm run --filter @linode/queries typecheck
 
+  typecheck-shared:
+    runs-on: ubuntu-latest
+    needs: build-sdk
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
+        with:
+          run_install: false
+          version: 10
+      - uses: actions/setup-node@v4
+        with:
+          node-version: "20.17"
+          cache: "pnpm"
+      - uses: actions/download-artifact@v4
+        with:
+          name: packages-api-v4-lib
+          path: packages/api-v4/lib
+      - uses: actions/download-artifact@v4
+        with:
+          name: packages-validation-lib
+          path: packages/validation/lib
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm run --filter @linode/shared typecheck
+    
   typecheck-manager:
     runs-on: ubuntu-latest
     needs: build-sdk

README.md

@@ -45,6 +45,7 @@ This repository is home to the Akamai Connected **[Cloud Manager](https://cloud.
 - [`@linode/api-v4`](packages/api-v4/)
 - [`@linode/queries`](packages/queries/)
 - [`@linode/search`](packages/search/)
+- [`@linode/shared`](packages/shared/)
 - [`@linode/ui`](packages/ui/)
 - [`@linode/utilities`](packages/utilities/)
 - [`@linode/validation`](packages/validation/)

package.json

@@ -19,8 +19,8 @@
     "build:analyze": "pnpm run --filter linode-manager build:analyze",
     "bootstrap": "pnpm install:all && pnpm build:validation && pnpm build:sdk",
     "up:expose": "npm_config_package_import_method=clone-or-copy pnpm install:all && pnpm build:validation && pnpm build:sdk && pnpm start:all:expose",
-    "dev": "concurrently -n api-v4,validation,ui,utilities,queries,manager -c blue,yellow,magenta,cyan,gray,green \"pnpm run --filter @linode/api-v4 start\" \"pnpm run --filter @linode/validation start\" \"pnpm run --filter @linode/ui start\" \"pnpm run --filter @linode/utilities start\" \"pnpm run --filter @linode/queries start\" \"pnpm run --filter linode-manager start\"",
-    "start:all:expose": "concurrently -n api-v4,validation,ui,utilities,queries,manager -c blue,yellow,magenta,cyan,gray,green \"pnpm run --filter @linode/api-v4 start\" \"pnpm run --filter @linode/validation start\" \"pnpm run --filter @linode/ui start\" \"pnpm run --filter @linode/utilities start\" \"pnpm run --filter @linode/queries start\" \"pnpm run --filter linode-manager start:expose\"",
+    "dev": "concurrently -n api-v4,validation,ui,utilities,queries,shared,manager -c blue,yellow,magenta,cyan,gray,blue,green \"pnpm run --filter @linode/api-v4 start\" \"pnpm run --filter @linode/validation start\" \"pnpm run --filter @linode/ui start\" \"pnpm run --filter @linode/utilities start\" \"pnpm run --filter @linode/queries start\" \"pnpm run --filter @linode/shared start\" \"pnpm run --filter linode-manager start\"",
+    "start:all:expose": "concurrently -n api-v4,validation,ui,utilities,queries,shared,manager -c blue,yellow,magenta,cyan,gray,blue,green \"pnpm run --filter @linode/api-v4 start\" \"pnpm run --filter @linode/validation start\" \"pnpm run --filter @linode/ui start\" \"pnpm run --filter @linode/utilities start\" \"pnpm run --filter @linode/queries start\" \"pnpm run --filter @linode/shared start\" \"pnpm run --filter linode-manager start:expose\"",
     "start:manager": "pnpm --filter linode-manager start",
     "start:manager:ci": "pnpm run --filter linode-manager start:ci",
     "docs": "bunx [email protected] dev docs",

packages/manager/.changeset/pr-11844-removed-1742228203939.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Removed
+---
+
+Move `LinodeSelect` to new `shared` package ([#11844](https://github.com/linode/manager/pull/11844))

packages/manager/.storybook/main.ts

@@ -5,6 +5,7 @@ const config: StorybookConfig = {
   stories: [
     '../src/components/**/*.@(mdx|stories.@(js|ts|jsx|tsx))',
     '../src/features/**/*.@(mdx|stories.@(js|ts|jsx|tsx))',
+    '../../shared/src/**/*.@(mdx|stories.@(js|ts|jsx|tsx))',
     '../../ui/src/components/**/*.@(mdx|stories.@(js|ts|jsx|tsx))',
   ],
   addons: [

packages/manager/cypress/e2e/core/account/account-linode-managed.spec.ts

@@ -2,6 +2,7 @@
  * @file Integration tests for Cloud Manager account enable Linode Managed flows.
  */
 
+import { linodeFactory } from '@linode/utilities';
 import {
   visitUrlWithManagedDisabled,
   visitUrlWithManagedEnabled,
@@ -21,7 +22,6 @@ import { ui } from 'support/ui';
 import { chooseRegion } from 'support/util/regions';
 
 import { accountFactory } from 'src/factories/account';
-import { linodeFactory } from 'src/factories/linodes';
 import { profileFactory } from 'src/factories/profile';
 
 import type { Linode } from '@linode/api-v4';

packages/manager/cypress/e2e/core/account/service-transfer.spec.ts

@@ -3,6 +3,7 @@
  */
 
 import { getProfile } from '@linode/api-v4/lib/profile';
+import { createLinodeRequestFactory, linodeFactory } from '@linode/utilities';
 import { authenticate } from 'support/api/authentication';
 import { visitUrlWithManagedEnabled } from 'support/api/managed';
 import {
@@ -21,13 +22,15 @@ import { pollLinodeStatus } from 'support/util/polling';
 import { randomLabel, randomUuid } from 'support/util/random';
 import { chooseRegion } from 'support/util/regions';
 
-import { linodeFactory } from 'src/factories';
 import { entityTransferFactory } from 'src/factories/entityTransfers';
-import { createLinodeRequestFactory } from 'src/factories/linodes';
 import { formatDate } from 'src/utilities/formatDate';
 
-import type { EntityTransferStatus } from '@linode/api-v4';
-import type { EntityTransfer, Linode, Profile } from '@linode/api-v4';
+import type {
+  EntityTransfer,
+  EntityTransferStatus,
+  Linode,
+  Profile,
+} from '@linode/api-v4';
 
 // Service transfer empty state message.
 const serviceTransferEmptyState = 'No data to display.';

packages/manager/cypress/e2e/core/cloudpulse/dbaas-widgets-verification.spec.ts

@@ -1,7 +1,7 @@
 /**
  * @file Integration Tests for CloudPulse Dbass Dashboard.
  */
-import { regionFactory } from '@linode/utilities';
+import { linodeFactory, regionFactory } from '@linode/utilities';
 import { widgetDetails } from 'support/constants/widgets';
 import { mockGetAccount } from 'support/intercepts/account';
 import {
@@ -27,7 +27,6 @@ import {
   dashboardMetricFactory,
   databaseFactory,
   kubeLinodeFactory,
-  linodeFactory,
   widgetFactory,
 } from 'src/factories';
 import { generateGraphData } from 'src/features/CloudPulse/Utils/CloudPulseWidgetUtils';

packages/manager/cypress/e2e/core/cloudpulse/linode-widget-verification.spec.ts

@@ -1,7 +1,7 @@
 /**
  * @file Integration Tests for CloudPulse Linode Dashboard.
  */
-import { regionFactory } from '@linode/utilities';
+import { linodeFactory, regionFactory } from '@linode/utilities';
 import { widgetDetails } from 'support/constants/widgets';
 import { mockGetAccount } from 'support/intercepts/account';
 import {
@@ -25,7 +25,6 @@ import {
   dashboardFactory,
   dashboardMetricFactory,
   kubeLinodeFactory,
-  linodeFactory,
   widgetFactory,
 } from 'src/factories';
 import { generateGraphData } from 'src/features/CloudPulse/Utils/CloudPulseWidgetUtils';

packages/manager/cypress/e2e/core/firewalls/create-firewall.spec.ts

@@ -1,13 +1,11 @@
+import { createLinodeRequestFactory } from '@linode/utilities';
 import { authenticate } from 'support/api/authentication';
 import { interceptCreateFirewall } from 'support/intercepts/firewalls';
 import { ui } from 'support/ui';
 import { cleanUp } from 'support/util/cleanup';
 import { createTestLinode } from 'support/util/linodes';
 import { randomLabel, randomString } from 'support/util/random';
 import { chooseRegion } from 'support/util/regions';
-
-import { createLinodeRequestFactory } from 'src/factories/linodes';
-
 authenticate();
 describe.skip('create firewall', () => {
   before(() => {