Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #7
Testing was previously tracked in #52. This PR now only implements agent tests
The agent cannot be tested using common JavaScript/Node testing frameworks since the environment, for example, does not have a
globalvariable, but one calledglobal. And we must test it on devices, not mock mobile OS data types, etc.So I made a (very tiny) testing framework located in
agent/tests/test-framework.ts. The tests can be run using these node scripts:test:androidtest:iosThey basically run
run-tests.jswhich implements the host logic:org.owap.mastestappagent/tests/androidoragent/tests/iosrespectively. They are fully asynchronous.The tests are written like Jests-Tests:
What is not yet implemented is the GitHub Action. But this can be done like that:
npm run test:androidornpm run test:iosThis is the output the android test:
The process will return 0 if all goes well.