-
Notifications
You must be signed in to change notification settings - Fork 586
Remove Errors For URL Parser #5756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ryanchou-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! i think it'd also be good to have a small error message letting them know that the parsing failed (and that they can edit the unknown fields after pasting).
Sosuke23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works perfectly fine.
that’s a good idea |
|
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution! |
|
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution! |
Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.
I removed the errors that were thrown and just put "Unknown" as placeholders for values that could not be determined. This should allow for manual editing