jump to defn based on Locate Library loop and .glob files#265
Draft
aa755 wants to merge 2 commits intocpitclaudel:masterfrom
Draft
jump to defn based on Locate Library loop and .glob files#265aa755 wants to merge 2 commits intocpitclaudel:masterfrom
aa755 wants to merge 2 commits intocpitclaudel:masterfrom
Conversation
aa755
commented
Nov 30, 2022
| "\\s-*\\(" (regexp-quote short-name) "\\)\\_>")))) | ||
| (short-name (replace-regexp-in-string "\\`.*\\." "" fqn))) | ||
| (or (-when-let* ((loc (company-coq--loc-fully-qualified-name fqn));; will fail iff the definition is in current file | ||
| (vfile (concat (replace-regexp-in-string "_build/default" "" (car loc) nil 'literal) ".v")) |
Contributor
Author
There was a problem hiding this comment.
to be on the safer side, check that the parent directory of _build has a dune-project file
…e resolution: when globfile is present, jump to constructor now works even the inductive is inside a module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 major changes
Locate Libraryloop on prefixes of fully quantified name, as @cpitclaudel proposed here. This is more robust in our work at bedrock systems where we use a lot of elpi code-generation stuff likeNESwhich creates modules. When trying to jump to such definitions, the current implementation always tries to open the wrong file.(this MR is currently in DRAFT state to seek feedback and/or suggestions on better ways to implement the functionality. I still have some debugging stuff in. I will remove them once I use the new implementation for about a week to fix any bugs that pop up)