Add script for verifying source code changes #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use the new script in the check-pr.yml workflow.
Dani-Hub
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the new script in the check-pr.yml workflow.
The new script can be used to check that changes to the C++ code do not produce unwanted differences in the generated HTML. That can be used in the workflow that runs on pull requests.
Here's an example of the output when the generated HTML changes:
https://github.com/jwakely/LWG/actions/runs/11674543132/job/32507431334
Expanding the "> Annotations" output and clicking on the warning jumps to the diff for the generated HTML files.