[basic][expr] Declare but not define typedef-names in standard headers #6435
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
changed the title
Contributor
|
Seems correct to me. Thoughts @jensmaurer? |
jensmaurer
approved these changes
Jan 21, 2025
Member
jensmaurer
left a comment
jensmaurer
left a comment
There was a problem hiding this comment.
[basic.def] p2.9 says that typedefs are never definitions, so this is a strict improvement.
tkoeppe
force-pushed
the
declare-typedef-names-core
branch
from
c97427a to
05fc5f5
Compare
tkoeppe
force-pushed
the
declare-typedef-names-core
branch
from
05fc5f5 to
24a7cd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since (non-template) typedef-names are declared but not defined ([basic.def]/2.9, [basic.def]/2.10).