[exec.snd.expos] Fix markup of exposition-only identifiers in basic-state constructor
#7304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
requested changes
Oct 15, 2024
Member
jensmaurer
left a comment
jensmaurer
left a comment
There was a problem hiding this comment.
Using two variables in scope that have the same name except for italics feels unfortunate. But oh well.
Could you please annotate "state" with \exposid in the mem-initializer-list as well?
…state` constructor The initialization of the exposition-only `recv` and `state` data-members in the `basic-state` constructor should have marked-up the member identifiers using \exposid. Also, the `recv` argument passed to `get-state` was supposed to be referring to the exposition-only data-member rather than the parameter of the same name as otherwise it would be referring to a moved-from object. So markup the `recv` argument to `get-state` using \exposid as well to make this (slightly) clearer.
lewissbaker
changed the title
recv identifier in basic-state constructorbasic-state constructor
jensmaurer
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialization of the exposition-only
recvandstatedata-members in the
basic-stateconstructor should have marked-upthe member identifiers using \exposid.
Also, the
recvargument passed toget-statewas supposed to bereferring to the exposition-only data-member rather than the parameter
of the same name as otherwise it would be referring to a moved-from
object.
So markup the
recvargument toget-stateusing \exposid as wellto make this (slightly) clearer.