Skip to content

Conversation

@eisenwave
Copy link
Member

The lack of commas in [basic.link] p4 really had me stumped for a few minutes because I thought it should be read as:

The name of an entity that belongs to a
    namespace scope that has not been given internal linkage above
and that is the name of ...

... when the intended reading is

The name of an entity
- that belongs to a namespace scope,
- that has not been given internal linkage above, and
- that is the name of ...

This PR adds an Oxford comma to make it immediately obvious which reading is intended.

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 23, 2024

The PR seems to do more than add an Oxford comma, and also adds an interior comma.

@jensmaurer Is it actually clear that this is editorial? The original wording could be taken to mean that that only "namespace scopes with internal linkage" are being considered. I realize that's probably not intended, but it sounds like that could be a valid reading.

@eisenwave
Copy link
Member Author

It would not be a meaningful reading (albeit grammatically valid) because [basic.link] p4.9 states:

otherwise, if the enclosing namespace has internal linkage, the name has internal linkage;

This is nonsensical if we read the whole paragraph as

[...] namespace scope that has not been given internal linkage above [...]

... because this bullet would never apply to anything.

Furthermore, the word "above" would have to apply to the sentence above, not to a prior paragraph above, which is more typical.

@jensmaurer
Copy link
Member

@tkoeppe, I agree the other reading is possible, but it yields a meaningless statement, so I think this is one of those "pellucidly obvious" cases.

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 24, 2024

OK, makes sense, thanks!

@tkoeppe tkoeppe merged commit d5174d5 into cplusplus:main Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants