Skip to content

Conversation

@mhoemmen
Copy link
Contributor

@mhoemmen mhoemmen commented Dec 18, 2024

  • Add Note explaining the SIMD acronym
  • Add bibliography entry to Flynn's original paper explaining the SISD, SIMD, MISD, MIMD taxonomy
  • Cite that paper in the Note

@mhoemmen mhoemmen marked this pull request as ready for review December 18, 2024 23:38
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rephrase the commit descriptions: https://github.com/cplusplus/draft/wiki/Commit-message-format

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 19, 2024
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 19, 2024
@mhoemmen
Copy link
Contributor Author

@jensmaurer wrote:

Please rephrase the commit descriptions: https://github.com/cplusplus/draft/wiki/Commit-message-format

Thanks Jens! I'll edit the commit messages to correspond to the "Editorial commits" format.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash all commits, fix the commit description to read something like

[simd.general] Explain SIMD acronym and add bibliography entry

and force-push.

Add bibliography entry for Flynn 1966, the paper that introduced what
later became known as "Flynn's Taxonomy."  This classifies parallel
computer hardware as SISD, SIMD, MISD, or MIMD.  Adding this entry
will let [simd] ("Data-parallel types") refer to this paper (a change
to be made in a future commit) when unpacking the "SIMD" abbreviation.
To the existing Note at the beginning of [simd.general],
add text that unpacks the SIMD acronym
and refers to Flynn 1966.
@mhoemmen
Copy link
Contributor Author

@jensmaurer wrote:

Squash all commits, fix the commit description to read something like [simd.general] Explain SIMD acronym and add bibliography entry and force-push.

Done! There are two commits now, one for the [bibliography] change and one for the [simd.general] change. Please let me know if you would like those two changes in one commit. Thanks!

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 19, 2024

Let me squash them, so that the reference is never "unused. Thank you!

@tkoeppe tkoeppe merged commit 8215379 into cplusplus:main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants