[util.smartptr.atomic.{shared,weak}] Fix wording for initialization #7583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using more conventional "value-initializes".
jensmaurer
approved these changes
Jan 24, 2025
Member
jensmaurer
left a comment
jensmaurer
left a comment
There was a problem hiding this comment.
p has class type with a non-trivial constructor. Even say "default-initializes" would work, or saying nothing and defaulting the default constructor. The latter is probably too large a hammer at this point.
@jwakely , I like the change proposed here as an incremental improvement.
Contributor
|
Agreed, this seems like a generally nicer way to express value initialization. @jwakely? |
jwakely
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using more conventional "value-initializes".
Fixes #7522.