[module.global.frag] Remove irrelevant note about preprocessor #8389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
previously approved these changes
Nov 3, 2025
Member
|
I've thought about this some more. I think the preprocessor treatment of the global module fragment is so surprisingly different from any other context that I would want to retain a cross-reference from phase 7 [module.global.frag] to [cpp.pre] in some form. |
[module.global.frag] is entirely part of phase 7 of translation, and it makes no sense to talk of preprocessing directive in the grammar term *declaration-seq*. Strike the note rather than try to turn it into something meaningful.
AlisdairM
force-pushed
the
meaningless_pp_note_in_global_frag
branch
from
2d87ef2 to
e0a9d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[module.global.frag] is entirely part of phase 7 of translation, and it makes no sense to talk of preprocessing directive in the grammar term declaration-seq. Strike the note rather than try to turn it into something meaningful.