Skip to content

Conversation

@jakubjelinek
Copy link
Contributor

@jakubjelinek jakubjelinek commented Nov 5, 2025

Fixes #8425.

@frederick-vs-ja

This comment was marked as resolved.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 5, 2025

Can you please update both the commit description (as per https://github.com/cplusplus/draft/wiki/Commit-message-format) and the first post (state Fixes #nnnn.)?

Note in particular that the commit message should not include any GitHub maintenance metadata.

@jensmaurer
Copy link
Member

For future pull requests, please see the help for the commit message format here: https://github.com/cplusplus/draft/wiki/Commit-message-format
(in particular, see "editorial commits")

In this case, we want something like

[expr.const] Use different classes for unrelated parts of the example

The "fixes" or "resolves" for the github machinery only goes into the pull request description, not into the commit message.

Please fix and force-push; thanks for your help!

@jakubjelinek jakubjelinek changed the title Issue #8425 - use different local class for different calls in the example [expr.const] Use different classes for unrelated parts of the example Nov 5, 2025
@tkoeppe tkoeppe merged commit c84e2cb into cplusplus:main Nov 5, 2025
2 checks passed
@jakubjelinek jakubjelinek deleted the issue8425 branch November 5, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[expr.const]/31 Small issue with example

4 participants