Skip to content

Conversation

@eisenwave
Copy link
Member

@eisenwave eisenwave commented Nov 14, 2025

Fixes #8460.

Fixes NB US 172-275 (C++26 CD).
Fixes NB US 171-274 (C++26 CD).
Fixes NB US 170-278 (C++26 CD).
Fixes NB US 252-387 (C++26 CD).
Fixes NB US 244-375 (C++26 CD).
Fixes NB US 237-369 (C++26 CD).
Fixes NB US 243-376 (C++26 CD).
Fixes NB US 251-388 (C++26 CD).
Fixes NB US 250-389 (C++26 CD).
Fixes NB US 258-381 (C++26 CD).
Fixes NB US 174-282 (C++26 CD).
Fixes NB PL-005 (C++26 CD).

Also fixes https://github.com/cplusplus/nbballot/issues/850
Also fixes https://github.com/cplusplus/nbballot/issues/849
Also fixes https://github.com/cplusplus/nbballot/issues/853
Also fixes https://github.com/cplusplus/nbballot/issues/962
Also fixes https://github.com/cplusplus/nbballot/issues/950
Also fixes https://github.com/cplusplus/nbballot/issues/944
Also fixes https://github.com/cplusplus/nbballot/issues/951
Also fixes https://github.com/cplusplus/nbballot/issues/963
Also fixes https://github.com/cplusplus/nbballot/issues/964
Also fixes https://github.com/cplusplus/nbballot/issues/956
Also fixes https://github.com/cplusplus/nbballot/issues/857
Also fixes https://github.com/cplusplus/nbballot/issues/793

@eisenwave eisenwave added this to the post-2025-11 milestone Nov 14, 2025
@eisenwave eisenwave marked this pull request as draft November 14, 2025 13:18
@eisenwave eisenwave changed the title LWG4137 Fix Mandates, Preconditions, and Complexity elements of [lina… P3905R0 C++ Standard Library Ready Issues to be moved in Kona Nov 14, 2025
@eisenwave

This comment was marked as resolved.

@eisenwave
Copy link
Member Author

LWG4300 cannot be done because #8507 already implements the change.

@jwakely
Copy link
Member

jwakely commented Nov 14, 2025

Weird. LWG4269 has already been applied editorially or something.

Are you looking at p1? The change is to p6 (and intends to make it consistent with p1)

@eisenwave eisenwave marked this pull request as ready for review November 14, 2025 18:09
@eisenwave eisenwave force-pushed the motions-2025-11-lwg-1 branch from 39861b8 to 8d09815 Compare November 23, 2025 19:15
Comment on lines -5140 to 5147
\tcode{access_context} is a structural type.
Two values \tcode{ac1} and \tcode{ac2} of type \tcode{access_context}
\tcode{access_context} is a structural, consteval-only, non-aggregate type.
Two values \tcode{ac1} and \tcode{ac2} of type \linebreak \tcode{access_context}
are template-argument-equivalent\iref{temp.type}
if \tcode{ac1.scope()} and \tcode{ac2.scope()}
are template-argument-equivalent
are \linebreak template-argument-equivalent
and \tcode{ac1.desig\-nating_class()} and \tcode{ac2.desig\-nating_class()}
are template-argument-equivalent.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a working solution for the overfull hbox in this area, be my guest to suggest it.

I've tried pretty much everything, and \linebreaks were a measure of last resort.

@eisenwave eisenwave requested a review from jwakely November 23, 2025 19:18
@jwakely jwakely self-assigned this Nov 28, 2025
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important that the order of operands is preserved in optional comparisons, so *x == v and v == *x are not interchangeable.

@jwakely
Copy link
Member

jwakely commented Nov 28, 2025

Weird. LWG4269 has already been applied editorially or something.

Are you looking at p1? The change is to p6 (and intends to make it consistent with p1)

The "LWG4269 FIXME unique_copy passes arguments to its predicate backwards FIXME MERGE THIS FIXME MERGE THIS WITH PREVIOUS COMMIT FIXME" commit should be merged with the one for 4269, which is not the previous commit. You would need to do an interactive rebase to put it in the right order in the commit graph.

…-sender::connect()

Fixes NB US 237-369 (C++26 CD).
Fixes NB US 258-381 (C++26 CD).
@eisenwave eisenwave force-pushed the motions-2025-11-lwg-1 branch from 8d09815 to d7cb114 Compare December 4, 2025 07:35
@eisenwave eisenwave requested a review from jwakely December 4, 2025 07:38
@eisenwave
Copy link
Member Author

@jwakely it's impractical not to force-push for these omnibus PRs. Check https://github.com/cplusplus/draft/compare/8d09815eeeff6faecc7bbe2b4b6fbb972de6f6b6..d7cb114c218f79c9d4bbfcb86a8333ced87c6abb for the differences made by the force-push.

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2025-11 LWG Motion 1] P3905R0 C++ Standard Library Ready Issues to be moved in Kona

2 participants