-
Notifications
You must be signed in to change notification settings - Fork 802
P3905R0 C++ Standard Library Ready Issues to be moved in Kona #8517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Are you looking at p1? The change is to p6 (and intends to make it consistent with p1) |
…lg] algorithms Fixes NB US 172-275 (C++26 CD).
…_norm Fixes NB US 171-274 (C++26 CD).
39861b8 to
8d09815
Compare
| \tcode{access_context} is a structural type. | ||
| Two values \tcode{ac1} and \tcode{ac2} of type \tcode{access_context} | ||
| \tcode{access_context} is a structural, consteval-only, non-aggregate type. | ||
| Two values \tcode{ac1} and \tcode{ac2} of type \linebreak \tcode{access_context} | ||
| are template-argument-equivalent\iref{temp.type} | ||
| if \tcode{ac1.scope()} and \tcode{ac2.scope()} | ||
| are template-argument-equivalent | ||
| are \linebreak template-argument-equivalent | ||
| and \tcode{ac1.desig\-nating_class()} and \tcode{ac2.desig\-nating_class()} | ||
| are template-argument-equivalent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a working solution for the overfull hbox in this area, be my guest to suggest it.
I've tried pretty much everything, and \linebreaks were a measure of last resort.
jwakely
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's important that the order of operands is preserved in optional comparisons, so *x == v and v == *x are not interchangeable.
The "LWG4269 FIXME unique_copy passes arguments to its predicate backwards FIXME MERGE THIS FIXME MERGE THIS WITH PREVIOUS COMMIT FIXME" commit should be merged with the one for 4269, which is not the previous commit. You would need to do an interactive rebase to put it in the right order in the commit graph. |
…the conversion" intended to mean?
… with nonzero imaginary part Fixes NB US 170-278 (C++26 CD).
Fixes NB US 252-387 (C++26 CD).
Fixes NB US 244-375 (C++26 CD).
…-sender::connect() Fixes NB US 237-369 (C++26 CD).
Fixes NB US 243-376 (C++26 CD).
Fixes NB US 251-388 (C++26 CD).
Fixes NB US 250-389 (C++26 CD).
Fixes NB US 258-381 (C++26 CD).
…or container adaptors
…eeds remove_cvref_t
Fixes NB US-174-282 (C++26 CD).
…ept signature Fixes NB PL-005 (C++26 CD).
8d09815 to
d7cb114
Compare
|
@jwakely it's impractical not to force-push for these omnibus PRs. Check https://github.com/cplusplus/draft/compare/8d09815eeeff6faecc7bbe2b4b6fbb972de6f6b6..d7cb114c218f79c9d4bbfcb86a8333ced87c6abb for the differences made by the force-push. |
jwakely
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great now, thanks!
Fixes #8460.
Fixes NB US 172-275 (C++26 CD).
Fixes NB US 171-274 (C++26 CD).
Fixes NB US 170-278 (C++26 CD).
Fixes NB US 252-387 (C++26 CD).
Fixes NB US 244-375 (C++26 CD).
Fixes NB US 237-369 (C++26 CD).
Fixes NB US 243-376 (C++26 CD).
Fixes NB US 251-388 (C++26 CD).
Fixes NB US 250-389 (C++26 CD).
Fixes NB US 258-381 (C++26 CD).
Fixes NB US 174-282 (C++26 CD).
Fixes NB PL-005 (C++26 CD).
Also fixes https://github.com/cplusplus/nbballot/issues/850
Also fixes https://github.com/cplusplus/nbballot/issues/849
Also fixes https://github.com/cplusplus/nbballot/issues/853
Also fixes https://github.com/cplusplus/nbballot/issues/962
Also fixes https://github.com/cplusplus/nbballot/issues/950
Also fixes https://github.com/cplusplus/nbballot/issues/944
Also fixes https://github.com/cplusplus/nbballot/issues/951
Also fixes https://github.com/cplusplus/nbballot/issues/963
Also fixes https://github.com/cplusplus/nbballot/issues/964
Also fixes https://github.com/cplusplus/nbballot/issues/956
Also fixes https://github.com/cplusplus/nbballot/issues/857
Also fixes https://github.com/cplusplus/nbballot/issues/793