-
Notifications
You must be signed in to change notification settings - Fork 802
P3914R0 Assorted NB comment resolutions for Kona 2025 #8527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eisenwave
wants to merge
8
commits into
cplusplus:main
Choose a base branch
from
eisenwave:motions-2025-11-lwg-6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+116
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsong-cpp
suggested changes
Nov 16, 2025
Fixes NB US 160-260 (C++26 CD).
Fixes NB US 209-332 (C++26 CD).
Fixes NB US 228-348 (C++26 CD).
Fixes NB US 263-396 (C++26 CD).
497da84 to
efeff2c
Compare
timsong-cpp
reviewed
Nov 24, 2025
efeff2c to
886b9cc
Compare
jwakely
requested changes
Nov 28, 2025
Fixes NB US 265-398 and US 266-399 (C++26 CD).
Fixes NB US 112-172 (C++26 CD).
Fixes NB US 130-193 (C++26 CD).
886b9cc to
7eca145
Compare
jwakely
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8465.
Fixes NB US 160-260 (C++26 CD).
Fixes NB US 209-332 (C++26 CD).
Fixes NB US 228-348 (C++26 CD).
Fixes NB US 263-396 (C++26 CD).
Fixes NB US 265-398 (C++26 CD).
Fixes NB US 266-399 (C++26 CD).
Fixes NB US 112-172 (C++26 CD).
Fixes NB US 130-193 (C++26 CD).
Also fixes https://github.com/cplusplus/nbballot/issues/835
Also fixes https://github.com/cplusplus/nbballot/issues/907
Also fixes https://github.com/cplusplus/nbballot/issues/923
Also fixes https://github.com/cplusplus/nbballot/issues/971
Also fixes https://github.com/cplusplus/nbballot/issues/973
Also fixes https://github.com/cplusplus/nbballot/issues/974
Also fixes https://github.com/cplusplus/nbballot/issues/990
Also fixes https://github.com/cplusplus/nbballot/issues/762