P3923R0 Additional NB comment resolutions for Kona 2025 #8536
+153
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisenwave
added
the
changes requested
timsong-cpp
reviewed
Nov 24, 2025
Fixes NB AT 7-213 (C++26 CD).
Fixes NB US 140-233 (C++26 CD).
Fixes NB US 141-235 (C++26 CD).
Fixes NB US 145-234 (C++26 CD).
Fixes NB US 147-240 (C++26 CD).
eisenwave
force-pushed
the
motions-2025-11-lwg-19
branch
from
f7ba14c to
d402a70
Compare
eisenwave
removed
the
changes requested
eisenwave
commented
Nov 24, 2025
Fixes NB US 164-263 (C++26 CD).
Fixes NB US 126-189 (C++26 CD).
Fixes NB US 227-346 and US 229-347 (C++26 CD).
Fixes NB US 221-339 (C++26 CD).
Fixes NB US 225-341 (C++26 CD).
eisenwave
force-pushed
the
motions-2025-11-lwg-19
branch
from
d402a70 to
3aebb04
Compare
jwakely
reviewed
Nov 27, 2025
| void @\exposid{destroy}@() noexcept; // \expos | ||
| }; | ||
|
|
||
| template<class Alloc, @\libconcept{scope_token}@ Token, @\libconcept{sender}@ Sender, class Env> // \expos |
Member
There was a problem hiding this comment.
Do we need the \expos comment here? It's not in the paper.
Where is this deduction guide used, only in the spec, or is its existence observable to users?
Member
Author
There was a problem hiding this comment.
I think it may get used somehow by spawn_future; https://eel.is/c++draft/exec#spawn.future-17
Anyhow, it felt intuitively necessary, but I'm really not sure whether it actually is.
jwakely
reviewed
Nov 27, 2025
jwakely
reviewed
Nov 27, 2025
jwakely
reviewed
Nov 27, 2025
jwakely
reviewed
Nov 27, 2025
jwakely
reviewed
Nov 27, 2025
jwakely
reviewed
Nov 27, 2025
jwakely
requested changes
Nov 27, 2025
Member
jwakely
left a comment
jwakely
left a comment
There was a problem hiding this comment.
Non-urgent whitespace changes, and a question about an \expos marker.
jwakely
approved these changes
Dec 4, 2025
Member
jwakely
left a comment
jwakely
left a comment
There was a problem hiding this comment.
Looks good.
We need a decision about the \expos on the spawn-future-state deduction guide, but that doesn't need to block merging this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8478
Fixes NB AT 7-213 (C++26 CD).
Fixes NB US 140-233 (C++26 CD).
Fixes NB US 141-235 (C++26 CD).
Fixes NB US 145-234 (C++26 CD).
Fixes NB US 147-240 (C++26 CD).
Fixes NB US 164-263 (C++26 CD).
Fixes NB US 126-189 (C++26 CD).
Fixes NB US 227-346 (C++26 CD).
Fixes NB US 229-347 (C++26 CD).
Fixes NB US 221-339 (C++26 CD).
Fixes NB US 225-341 (C++26 CD).
Also fixes https://github.com/cplusplus/nbballot/issues/782
Also fixes https://github.com/cplusplus/nbballot/issues/804
Also fixes https://github.com/cplusplus/nbballot/issues/806
Also fixes https://github.com/cplusplus/nbballot/issues/805
Also fixes https://github.com/cplusplus/nbballot/issues/811
Also fixes https://github.com/cplusplus/nbballot/issues/838
Also fixes https://github.com/cplusplus/nbballot/issues/758
Also fixes https://github.com/cplusplus/nbballot/issues/921
Also fixes https://github.com/cplusplus/nbballot/issues/922
Also fixes https://github.com/cplusplus/nbballot/issues/914
Also fixes https://github.com/cplusplus/nbballot/issues/916