Skip to content

Conversation

@eisenwave
Copy link
Member

@eisenwave eisenwave commented Nov 17, 2025

This is a follow-up from #8541 (review)

As Jens pointed out, we have two uses of "cv-unqualified signed or unsigned".

The "cv-unqualified" should be removed because it is redundant. The set of "signed or unsigned" integers doesn't include any cv-qualified types, and having it here misleads the reader into thinking that in other places, cv-qualifications are included in that set.

Note

We have at least 28 uses of signed (and|or) unsigned in the standard, and other uses don't say "cv-unqualified".
I've checked those other uses, and the two addressed in this PR are the only ones that use "cv-unqualified", so we achive global consistency.

@eisenwave eisenwave added the P3-Other Triaged issue not in P1 or P2 label Nov 17, 2025
@frederick-vs-ja

This comment was marked as resolved.

@eisenwave

This comment was marked as resolved.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change.

CWG251 should probably be closed as NAD at this stage.

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update [utility.intcmp] to change:

Both T and U are standard integer types or extended integer types

to be consistent:

Both T and U are signed or unsigned integer types

It's needlessly confusing to talk about the set (signed integer types ∪ unsigned integer types) in most places and then talk about the set (standard integer types ∪ extended integer types) in another place, when those sets are equal.

@eisenwave
Copy link
Member Author

Yeah, it would be nice to make that change. Otherwise I will need to make wording changes in P3666 to that area; see

If it's phrased as "signed or unsigned", that would also include future support for bit-precise integers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3-Other Triaged issue not in P1 or P2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants