Open
Conversation
ScottBailey
force-pushed
the
bailey/sqlite_example
branch
from
25dad15 to
d867587
Compare
TheLartians
reviewed
Dec 22, 2024
| URL_HASH SHA256=712a7d09d2a22652fb06a49af516e051979a3984adb067da86760e60ed51a7f5 | ||
| PATCHES sqlite.patch | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
Thanks a lot for the extra example, this is an interesting use of the patches command! I'm a bit torn if we should encourage the use of the patches like this as the command still seems to have some issues. Until the command is more mature I think we should still encourage the old way of adding the library without using patches:
Suggested change
| if (sqlite_ADDDED) | |
| add_library( | |
| sqlite STATIC | |
| ${sqlite_SOURCE_DIR}/sqlite3.c | |
| ${sqlite_SOURCE_DIR}/sqlite3.h | |
| ${sqlite_SOURCE_DIR}/sqlite3ext.h | |
| ) | |
| target_include_directories(sqlite PUBLIC SYSTEM "${sqlite_SOURCE_DIR}") | |
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very simple example that adds sqlite from an amalgamation source.