Add support for GIT_SUBMODULES argument#687
Open
gillamkid wants to merge 1 commit intocpm-cmake:masterfrom
Open
Add support for GIT_SUBMODULES argument#687gillamkid wants to merge 1 commit intocpm-cmake:masterfrom
gillamkid wants to merge 1 commit intocpm-cmake:masterfrom
Conversation
Member
|
Thanks for raising the issue! We should definitely support this edge case. Three things
|
Member
|
@gillamkid note that this issue is also handled by #461, which resolves the issue in a more general way. The PR has gone stale due to lack of time from my side, but given the obvious need for a fix I will prioritise it. |
08f6972 to
fc0d339
Compare
Author
|
I added some unit tests and fixed the styling. @TheLartians can you please approve the Gitlab Actions workflow to run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPM does passthrough for many of the argument options of cmake's
FetchContent()function. Hwever, there was an argument of interest that it was not passing:GIT_SUBMODULES.GIT_SUBMODULESis needed if you want to useCPMAddPackage()and have it not initialize the submodules of the repo.I added support so
GIT_SUBMODULES ""can be used to prevent submodules from being initialized the same way it is used to do so when callingFetchContent()directly.