Skip to content

Conversation

@oskidan
Copy link

@oskidan oskidan commented Mar 28, 2022

Hi everyone,

I noticed that the template project did not allow a Darwin-based operating system (such as macOS) to be used as a development host.

This PR fixes that issue.

@ddalcino
Copy link
Contributor

Can you please move this PR upstream to https://github.com/cpp-best-practices/cpp_boilerplate_project? That’s where this kind of thing should be discussed. Thanks.

Are you able to use any of the Linux presets on Mac? You are right that we should support Mac better, but it surprises me that the Linux presets aren’t generic enough to work for you.

@oskidan
Copy link
Author

oskidan commented Mar 28, 2022

Can you please move this PR upstream to https://github.com/cpp-best-practices/cpp_boilerplate_project? That’s where this kind of thing should be discussed. Thanks.

OK, I will.

Are you able to use any of the Linux presets on Mac? You are right that we should support Mac better, but it surprises me that the Linux presets aren’t generic enough to work for you.

The presets themselves are generic enough. They can't be used on macOS because of this check: https://github.com/cpp-best-practices/ftxui_template/blob/69ccbc830fe8c81f81992e340aca081d90d98ba8/CMakePresets.json#L45-L49
If this check was modified to be "Linux" or "Darwin", everything would probably work fine. I don't know if VSCode CMake Tools allows that.

@oskidan
Copy link
Author

oskidan commented Mar 28, 2022

This is the PR in the cpp_boilerplate_project: cpp-best-practices/cmake_conan_boilerplate_template#16

@lefticus
Copy link
Member

Closing this one in favor of cpp-best-practices/cmake_conan_boilerplate_template#16

@lefticus lefticus closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants