port beast testing tools #68
Conversation
|
An automated preview of the documentation is available at https://68.http-io.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-10-21 13:43:40 UTC |
| if(ec == http_proto::condition::need_more_input) | ||
| { | ||
| // specific to http_io::async_read_some | ||
| if(total_bytes_ != 0 && condition_(pr_)) |
There was a problem hiding this comment.
This looks like a change unrelated to the test tools?
There was a problem hiding this comment.
The PR contains two commits: the first adds testing tools, and the second adds tests for read operations.
| system::error_code | ||
| make_error_code(error e) noexcept | ||
| { | ||
| static detail::error_cat_type const cat{}; |
There was a problem hiding this comment.
Don't we put this in the compiled lib these days?
There was a problem hiding this comment.
We decided to keep testing tools header only as its usage is optional.
| */ | ||
| class handler | ||
| { | ||
| boost::optional<system::error_code> ec_; |
There was a problem hiding this comment.
Do we really need optional here?
There was a problem hiding this comment.
It's used in any_handler where the handler might complete with an error or succeed.
|
|
||
| handler(handler&& other) | ||
| : ec_(other.ec_) | ||
| , invoked_(boost::exchange(other.invoked_, true)) |
There was a problem hiding this comment.
Does boost::exchange add another dependency?
There was a problem hiding this comment.
boost::exchange is in core.
| rts::context rts_ctx; | ||
| http_proto::install_parser_service(rts_ctx, {}); | ||
|
|
||
| // async_read completes when the parser reads |
There was a problem hiding this comment.
Oh yes this looks much better
ashtum
force-pushed
the
port-beast-test
branch
2 times, most recently
from
2541e0c to
b37593f
Compare
|
An automated preview of the documentation is available at https://68.beast2.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-10-22 08:15:20 UTC |
ashtum
force-pushed
the
port-beast-test
branch
8 times, most recently
from
0b9dd61 to
3bfe49b
Compare
ashtum
force-pushed
the
port-beast-test
branch
from
3bfe49b to
400ff23
Compare
3 participants
No description provided.