fix(ci): SLODD minimal build fix - add missing root Jamfile #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The B2 build system could not find libs/capy/test because there was no root Jamfile to delegate to build and test subprojects. Co-Authored-By: Claude <[email protected]>
Replace hardcoded libs/capy paths with ${GITHUB_REPOSITORY#*/} or
steps.patch.outputs.module to support repositories that are forks
or have different names.
Co-Authored-By: Claude <[email protected]>
The c20-requires constant was undefined in test/unit/Jamfile, causing B2 to fail with 'don't know how to make <e>libs/capy/test'. Added import of config:requires and replaced $(c20-requires) with the direct [ requires cxx20_hdr_concepts ] call. Co-Authored-By: Claude <[email protected]>
Author
SLODD Iteration 3 FixAdded fix for undefined Changes:
The B2 build was failing because 🤖 Generated with SLODD |
Changed BOOST_RUNTIME_SERVICES_BOOSTDEP to BOOST_CAPY_BOOSTDEP so the URL dependency is detected and cloned by the CI workflow. Co-Authored-By: Claude <[email protected]>
B2 could not find the test target due to missing project declaration. Added minimal `project ;` to allow B2 to recognize the test directory. Co-Authored-By: Claude <[email protected]>
Author
Additional Fix (Iteration 5)Added missing Error being fixed: Root cause: The Fix: Added minimal 🤖 Generated with Claude Code |
The B2 build system couldn't find the libs/capy/test target because the test/Jamfile had an anonymous project declaration. Co-Authored-By: Claude <[email protected]>
The B2 workflow was using a hardcoded 'capy' module name, but the repository is 'capy-ci-test'. This caused B2 to look for tests in libs/capy/test instead of libs/capy-ci-test/test. Use the dynamically computed module name from the patch step output. Co-Authored-By: Claude <[email protected]>
- Comment out unused parameter 'stop_was_requested' in when_all.cpp - Add GCC pragma to suppress false maybe-uninitialized warning in async_run.hpp Co-Authored-By: Claude <[email protected]>
Sized operator delete(void*, size_t) is not available on all compilers. Clang 15 with older libstdc++ headers does not have this overload. Co-Authored-By: Claude <[email protected]>
- Remove explicit destructor call in deallocate_embedded() to prevent UB when other coroutine frames still hold pointers to the wrapper - Rename test files with duplicate base names to avoid B2 target collision errors (error.cpp, executor.cpp, frame_allocator.cpp in subdirectories now have prefixed names) Co-Authored-By: Claude <[email protected]>
- Change when_all_runner move constructor from =delete to =default (required by coroutine return in Clang 14) - Refactor extract_results to avoid nested lambdas with pack expansion (triggers GCC 11 ICE in tsubst_pack_expansion) Co-Authored-By: Claude <[email protected]>
GCC 11 raises false-positive -Wmaybe-uninitialized warnings for std::optional<std::tuple<...>> in coroutine code. This is a known GCC bug with complex template instantiations in coroutines. Add pragma to suppress this warning in the test file. Co-Authored-By: Claude <[email protected]>
The issue: when async_run_task awaited a user task, the user task's frame (containing the embedded allocator wrapper) was destroyed before async_run_task's frame. This left async_run_task with a dangling pointer to the freed wrapper, causing use-after-free in operator delete. The fix: defer destruction of the user's task until after async_run_task is destroyed. This is done by: 1. Adding deferred_destroy_ member to promise_type 2. In transform_awaiter::await_resume, release ownership of the task and store the handle in deferred_destroy_ 3. In final_suspend::await_suspend, destroy the deferred handle AFTER destroying async_run_task's frame This ensures the wrapper (embedded in the first frame) outlives all frames that reference it. Co-Authored-By: Claude <[email protected]>
Add reference counting to frame_allocator_wrapper to defer deallocation of the embedded block until all child frames are deallocated. This fixes the use-after-free that occurred when child frames accessed the wrapper after the embedded block was freed. Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
The boost_install export fails when building standalone because dependencies are added with EXCLUDE_FROM_ALL. Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Latest Fix
Added project name
/boost/capy/testto test/Jamfile so B2 can discover the test target vialibs/capy/test.Problem
B2 builds were failing with:
Note on CMake test failures
The CMake coverage build shows 2 test failures (
boost.capy.taskandboost.capy.when_all) with "pure virtual method called" errors. This appears to be a separate issue in the production code related to coroutine frame allocator lifetime management, not addressed in this fix.🤖 Generated with Claude Code