Skip to content

Don't automatically include {fmt} #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mborland merged 2 commits into from
Oct 13, 2025
Merged

Don't automatically include {fmt} #1124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
721b903
Remove {fmt} support from convenience header
mborland Oct 13, 2025
fae4ed4
Update header include information in test and docs
mborland Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions doc/modules/ROOT/pages/format.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,15 @@ int main()
[#fmt_format]
== `<fmt/format.h>`

Support for `{fmt}` is available as long as `<fmt/format.h>` is present.
Support for `{fmt}` is also available.
All the above information on modifiers is the same for fmtlib, just in a different namespace (i.e. `fmt::` instead of `std::`).
The header `<boost/decimal/fmt_format.hpp>` is *NOT* part of the convenience header, because it is an optional dependency on a potentially compiled library.

[source, c++]
----
#include <fmt/format.h>
#include <boost/decimal.hpp> // or <boost/decimal/fmt_format.hpp>
#include <boost/decimal.hpp>
#include <boost/decimal/fmt_format.hpp>
#include <iostream>

int main()
Expand Down
4 changes: 0 additions & 4 deletions include/boost/decimal.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@
#include <boost/decimal/string.hpp>
#include <boost/decimal/uint128_t.hpp>

#ifndef BOOST_DECIMAL_BUILD_MODULE
#include <boost/decimal/fmt_format.hpp>
#endif

#if defined(__clang__) && !defined(__GNUC__)
# pragma clang diagnostic pop
#endif
Expand Down
1 change: 1 addition & 0 deletions test/test_format_fmtlib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#define FMT_HEADER_ONLY
#include <boost/decimal.hpp>
#include <boost/decimal/fmt_format.hpp>
#include <boost/core/lightweight_test.hpp>
#include <limits>

Expand Down