Skip to content

Conversation

@mborland
Copy link
Member

Closes: #341

I am going to leave this one as a draft for now. There are a number of compiler errors since I don't think the support for this is totally complete yet.

@mborland
Copy link
Member Author

Use: https://github.com/boostorg/multiprecision/pull/535/files as reference for implementation

@mborland
Copy link
Member Author

mborland commented Jan 6, 2025

GCC-13 and Clang-17 added full support for <format> so this should be feasible now.

@mborland mborland marked this pull request as ready for review January 7, 2025 16:17
@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (5ef5f0d) to head (37a0c24).
Report is 35 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #363     +/-   ##
=========================================
+ Coverage     98.7%   98.9%   +0.2%     
=========================================
  Files          223     225      +2     
  Lines        16738   16886    +148     
  Branches      1799    1804      +5     
=========================================
+ Hits         16517   16686    +169     
+ Misses         221     200     -21     
Files with missing lines Coverage Δ
include/boost/decimal/format.hpp 100.0% <100.0%> (ø)
test/test_format.cpp 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef5f0d...37a0c24. Read the comment docs.

@mborland mborland merged commit 50b689c into develop Jan 7, 2025
75 checks passed
@mborland mborland deleted the format branch January 7, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overloads for std::format

2 participants