Skip to content

Conversation

@ckormanyos
Copy link
Collaborator

No description provided.

@ckormanyos
Copy link
Collaborator Author

This PR is intended to handle #759

@ckormanyos
Copy link
Collaborator Author

ckormanyos commented Dec 15, 2024

Hi Matt (@mborland) CI metal is up to date and green. But there seems to be a problem on 5 old-ish runner images. I can't quite figure out on my own how to deal with that GLIBC version.

0s
Post job cleanup.
/usr/bin/docker exec  57bacc[1](https://github.com/cppalliance/decimal/actions/runs/12337976651/job/34432384485#step:15:1)e9454e1a9cc862e1aaf0043bae3458388deb[2](https://github.com/cppalliance/decimal/actions/runs/12337976651/job/34432384485#step:15:2)ae0c6e92e05e0cea1d26 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

@codecov
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.1%. Comparing base (695b678) to head (8d83b73).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #760     +/-   ##
=========================================
- Coverage     99.1%   99.1%   -0.0%     
=========================================
  Files          227     227             
  Lines        16863   17372    +509     
  Branches      1816    1814      -2     
=========================================
+ Hits         16708   17204    +496     
- Misses         155     168     +13     

see 92 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695b678...8d83b73. Read the comment docs.

@mborland
Copy link
Member

I can fix that on Monday. We now have to install our own Node because GHA broke it and won't rollback their "upgrades"

@mborland mborland merged commit defb2dc into develop Dec 16, 2024
61 of 63 checks passed
@mborland mborland deleted the update_metal_ci branch December 16, 2024 21:16
@ckormanyos
Copy link
Collaborator Author

fix that on Monday

Thank you Matt (@mborland)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants