-
Notifications
You must be signed in to change notification settings - Fork 13
Refactor serializer #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor serializer #137
Conversation
|
An automated preview of the documentation is available at https://137.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://137.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
|
||
| //--------------------------------------------------------- | ||
|
|
||
| class serializer::const_buf_gen_base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this declaration could be in src/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to instantiate const_buf_gen<ConstBufferSequence> for user-provided buffers.
5620864 to
a5ee891
Compare
|
An automated preview of the documentation is available at https://137.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://137.http-proto.prtest.cppalliance.org/gcovr/index.html |
a5ee891 to
4183089
Compare
|
An automated preview of the documentation is available at https://137.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://137.http-proto.prtest.cppalliance.org/gcovr/index.html |
4183089 to
1318efe
Compare
|
An automated preview of the documentation is available at https://137.http-proto.prtest.cppalliance.org/index.html |
Improvements:
* User-provided buffers are now type-erased and used directly, rather
than being copied into a flat buffer. This enables efficient
handling of buffer sequences with many elements.
* Chunk encoding now occurs within the main buffers, allowing
serialization of multiple chunks. This also improves buffer
consumption efficiency by reducing the total number of buffers.
* The number of internal states maintained by the serializer has been
reduced. This lowers memory overhead and simplifies reasoning about
the implementation.
1318efe to
c44cb03
Compare
|
An automated preview of the documentation is available at https://137.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://137.http-proto.prtest.cppalliance.org/gcovr/index.html |
Improvements:
User-provided buffers are now type-erased and used directly, rather than being copied into a flat buffer. This enables efficient handling of buffer sequences with many elements.
Chunk encoding now occurs within the main buffers, allowing serialization of multiple chunks. This also improves buffer consumption efficiency by reducing the total number of buffers.
The number of internal states maintained by the serializer has been reduced. This lowers memory overhead and simplifies reasoning about the implementation.