ci(danger): adjust large commit threshold

Author: alandefreitas

.github/workflows/ci.yml

@@ -26,10 +26,6 @@ jobs:
     container:
       image: ubuntu:24.04
     name: Generate Test Matrix
-    # Permissions allow Danger to read PR context and post comments.
-    permissions:
-      contents: read
-      pull-requests: write
     outputs:
       matrix: ${{ steps.cpp-matrix.outputs.matrix }}
       llvm-matrix: ${{ steps.llvm-matrix.outputs.llvm-matrix }}

util/danger/format.test.ts

@@ -19,6 +19,7 @@ describe("renderDangerReport", () => {
         ]);
         const result: DangerResult = {
             warnings: ["First issue", "Second issue"],
+            infos: [],
             summary,
         };
 
@@ -33,12 +34,23 @@ describe("renderDangerReport", () => {
         expect(output).toContain("## 🔝 Top Files");
     });
 
+    it("renders informational notes separately from warnings", () => {
+        const summary = summarizeScopes([{ filename: "src/lib/example.cpp", additions: 1, deletions: 0 }]);
+        const result: DangerResult = { warnings: [], infos: ["Large commit"], summary };
+
+        const output = renderDangerReport(result);
+
+        expect(output).toContain("## ℹ️ Info");
+        expect(output).toContain("[!NOTE]");
+        expect(output).toContain("Large commit");
+    });
+
     it("formats scope totals with bold metrics and consistent churn", () => {
         const summary = summarizeScopes([
             { filename: "src/lib/example.cpp", additions: 3, deletions: 1 },
             { filename: "src/test/example_test.cpp", additions: 2, deletions: 0 },
         ]);
-        const result: DangerResult = { warnings: [], summary };
+        const result: DangerResult = { warnings: [], infos: [], summary };
 
         const output = renderDangerReport(result);
 
@@ -53,7 +65,7 @@ describe("renderDangerReport", () => {
         const summary = summarizeScopes([
             { filename: "src/lib/old.cpp", additions: 0, deletions: 5, status: "removed" },
         ]);
-        const result: DangerResult = { warnings: [], summary };
+        const result: DangerResult = { warnings: [], infos: [], summary };
 
         const output = renderDangerReport(result);
         const sourceRow = output.split("\n").find((line) => line.startsWith("| Source"));

util/danger/format.ts

@@ -80,6 +80,14 @@ function renderWarnings(warnings: string[]): string {
     return ["## ⚠️ Warnings", blocks.join("\n\n")].join("\n");
 }
 
+function renderInfos(infos: string[]): string {
+    if (infos.length === 0) {
+        return "";
+    }
+    const blocks = infos.map((message) => ["> [!NOTE]", `> ${message}`].join("\n"));
+    return ["## ℹ️ Info", blocks.join("\n\n")].join("\n");
+}
+
 function countFileChanges(status: ScopeTotals["status"]): number {
     return status.added + status.modified + status.renamed + status.removed + status.other;
 }
@@ -207,6 +215,7 @@ export function renderDangerReport(result: DangerResult): string {
     const sections = [
         notice,
         renderWarnings(result.warnings),
+        renderInfos(result.infos),
         renderHighlights(result.summary.highlights),
         renderChangeTable(result.summary),
         renderTopChanges(result.summary),

util/danger/logic.test.ts

@@ -9,7 +9,7 @@
 //
 import { describe, expect, it } from "vitest";
 import {
-    commitSizeWarnings,
+    commitSizeInfos,
     parseCommitSummary,
     basicChecks,
     summarizeScopes,
@@ -51,21 +51,21 @@ describe("summarizeScopes", () => {
     });
 });
 
-describe("commitSizeWarnings", () => {
-    // Confirms that large non-test churn triggers a warning while ignoring test fixtures.
+describe("commitSizeInfos", () => {
+    // Confirms that large non-test churn emits an informational note while ignoring test fixtures.
     it("flags large non-test commits", () => {
         const commits: CommitInfo[] = [
             {
                 sha: "abc",
                 message: "feat: huge change",
                 files: [
-                    { filename: "src/lib/large.cpp", additions: 900, deletions: 200 },
+                    { filename: "src/lib/large.cpp", additions: 1800, deletions: 400 },
                     { filename: "test-files/golden-tests/out.xml", additions: 1000, deletions: 0 },
                 ],
             },
         ];
-        const warnings = commitSizeWarnings(commits);
-        expect(warnings.length).toBe(1);
+        const infos = commitSizeInfos(commits);
+        expect(infos.length).toBe(1);
     });
 });
 

util/danger/logic.ts

@@ -103,6 +103,7 @@ export interface DangerInputs {
  */
 export interface DangerResult {
     warnings: string[];
+    infos: string[];
     summary: ScopeReport;
 }
 
@@ -137,7 +138,7 @@ const scopeFormat = /^[a-z0-9._/-]+$/i;
 const typeSet = new Set(allowedTypes);
 const skipTestLabels = new Set(["no-tests-needed", "skip-tests", "tests-not-required"]);
 const skipTestMarkers = ["[skip danger tests]", "[danger skip tests]"];
-const nonTestCommitLimit = 800;
+const nonTestCommitLimit = 2000;
 
 /**
  * Format churn as a + / - pair with explicit signs.
@@ -443,7 +444,7 @@ export function validateCommits(commits: CommitInfo[]): { warnings: string[]; pa
  * @param commits commits with per-file stats.
  * @returns warning messages for commits that exceed the threshold.
  */
-export function commitSizeWarnings(commits: CommitInfo[]): string[] {
+export function commitSizeInfos(commits: CommitInfo[]): string[] {
     const messages: string[] = [];
     for (const commit of commits) {
         if (!commit.files || commit.files.length === 0) {
@@ -464,9 +465,9 @@ export function commitSizeWarnings(commits: CommitInfo[]): string[] {
 
         if (churn > nonTestCommitLimit && parsedType !== "refactor") {
             const shortSha = commit.sha.substring(0, 7);
-            // === Commit size warnings (non-test churn) ===
+            // === Commit size informational notes (non-test churn) ===
             messages.push(
-                `Commit \`${shortSha}\` (${summary}) changes ${churn} source lines. Consider splitting it into smaller, reviewable chunks.`,
+                `Commit \`${shortSha}\` (${summary}) touches ${churn} source lines (non-test). Large change; add reviewer context if needed.`,
             );
         }
     }
@@ -555,11 +556,12 @@ export function evaluateDanger(input: DangerInputs): DangerResult {
     const summary = summarizeScopes(input.files);
     const commitValidation = validateCommits(input.commits);
 
+    const infos = commitSizeInfos(input.commits);
+
     const warnings = [
         ...commitValidation.warnings,
-        ...commitSizeWarnings(input.commits),
         ...basicChecks(input, summary, commitValidation.parsed),
     ];
 
-    return { warnings, summary };
+    return { warnings, infos, summary };
 }

util/danger/runner.ts

@@ -116,7 +116,7 @@ export async function runDanger(): Promise<void> {
     });
 
     const warnings = [...fetchWarnings, ...evaluation.warnings];
-    const report = renderDangerReport({ ...evaluation, warnings });
+    const report = renderDangerReport({ warnings, infos: evaluation.infos, summary: evaluation.summary });
 
     markdown(report);
 }