Skip to content

Conversation

@alandefreitas
Copy link
Collaborator

Parent-based include-symbol propagation walked up to the translation unit, causing global symbols to be extracted even when include-symbols were restricted to namespaces.

fix #1121

@cppalliance cppalliance deleted a comment from github-actions bot Dec 4, 2025
@cppalliance-bot
Copy link

cppalliance-bot commented Dec 4, 2025

An automated preview of the documentation is available at https://1124.mrdocs.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-12-05 01:47:02 UTC

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Fails
🚫

Danger failed to run util/danger/dangerfile.ts.

Error Error

Cannot find module './format'
Require stack:
- /home/runner/work/mrdocs/mrdocs/util/danger/runner.ts
- util/danger/dangerfile.ts
- /home/runner/work/mrdocs/mrdocs/util/danger/node_modules/danger/distribution/runner/runners/inline.js
- /home/runner/work/mrdocs/mrdocs/util/danger/node_modules/danger/distribution/commands/danger-runner.js
Error: Cannot find module './format'
Require stack:
- /home/runner/work/mrdocs/mrdocs/util/danger/runner.ts
- util/danger/dangerfile.ts
- /home/runner/work/mrdocs/mrdocs/util/danger/node_modules/danger/distribution/runner/runners/inline.js
- /home/runner/work/mrdocs/mrdocs/util/danger/node_modules/danger/distribution/commands/danger-runner.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1207:15)
    at Module._load (node:internal/modules/cjs/loader:1038:27)
    at _module2.default._load (/home/runner/work/mrdocs/mrdocs/util/danger/node_modules/override-require/dist/overrideRequire.js:43:25)
    at Module.require (node:internal/modules/cjs/loader:1289:19)
    at require (node:internal/modules/helpers:182:18)
    at Object.<anonymous> (/home/runner/work/mrdocs/mrdocs/util/danger/runner.ts:5:18)
    at Module._compile (node:internal/modules/cjs/loader:1521:14)
    at Object.customModuleHandler (/home/runner/work/mrdocs/mrdocs/util/danger/node_modules/danger/distribution/runner/runners/inline.js:134:28)
    at Module.load (node:internal/modules/cjs/loader:1266:32)
    at Module._load (node:internal/modules/cjs/loader:1091:12)

Dangerfile

-------------------^

Generated by 🚫 dangerJS against bc6e211

simplify llvm build and build llvm on cache miss instead of website download.

- Remove website download/publish steps for LLVM; cache misses now fetch sources and build locally before caching.
- Simplifies CI by relying solely on GitHub Actions cache for LLVM artifacts and dropping the external website dependency.
- Developers don't need help to update download binaries anymore. The local build became reasonable with the slim llvm build.
Parent-based include-symbol propagation walked up to the translation unit, causing global symbols to be extracted even when include-symbols were restricted to namespaces.

fix cppalliance#1121
@alandefreitas alandefreitas merged commit c3dbded into cppalliance:develop Dec 5, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

global symbols are regularly extracted even if not included by include-symbols

2 participants