Skip to content

fix: tables have no enumerator anchors #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: tables have no enumerator anchors #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions share/mrdocs/addons/generator/adoc/partials/symbol.adoc.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,23 @@
{{>symbol/tranche tranche=symbol.interface label="" is-namespace=true}}

{{/if}}
{{else if symbol.members}}
{{else if (and symbol.members (ne symbol.kind "overloads"))}}
{{! Members }}
{{#if (and symbol.members (ne symbol.kind "overloads"))}}
{{#> markup/dynamic-level-h }}Members{{/markup/dynamic-level-h}}

[,cols=2]
|===
|Name |Description
{{#each symbol.members}}
|xref:{{{anchor}}}[`pass:v[{{>symbol/name . nolink=true}}]`] | {{~doc.brief}}
{{#if (ne kind "enumerator")}}
|xref:{{{anchor}}}[`{{>symbol/name . nolink=true}}`]
{{else}}
|`{{>symbol/name . nolink=true}}`
{{/if}}
|{{~doc.brief}}
{{/each}}
|===

{{/if}}
{{/if}}
{{! Using directives }}
{{#if symbol.usingDirectives}}
Expand Down
4 changes: 4 additions & 0 deletions share/mrdocs/addons/generator/html/partials/symbol.html.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@
<tbody>
{{#each symbol.members}}
<tr>
{{#if (ne kind "enumerator")}}
<td><a href="#{{anchor}}">{{>symbol/name . nolink=true}}</a></td>
{{else}}
<td>{{>symbol/name . nolink=true}}</td>
{{/if}}
<td>{{{doc.brief}}}</td>
</tr>
{{/each}}
Expand Down
24 changes: 16 additions & 8 deletions test-files/golden-tests/enum.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,12 @@ enum E0;
[,cols=2]
|===
|Name |Description
|xref:E0-e0[`pass:v[e0]`] |pass:[
|`e0`
|pass:[
e0 brief.
]
|xref:E0-e1[`pass:v[e1]`] |pass:[
|`e1`
|pass:[
e1 brief.
]
|===
Expand Down Expand Up @@ -119,8 +121,10 @@ enum E1 : char;
[,cols=2]
|===
|Name |Description
|xref:E1-e2[`pass:v[e2]`] |
|xref:E1-e3[`pass:v[e3]`] |
|`e2`
|
|`e3`
|
|===

[#E1-e2]
Expand Down Expand Up @@ -165,10 +169,12 @@ enum E2 : int;
[,cols=2]
|===
|Name |Description
|xref:E2-e4[`pass:v[e4]`] |pass:[
|`e4`
|pass:[
e4 brief.
]
|xref:E2-e5[`pass:v[e5]`] |pass:[
|`e5`
|pass:[
e5 brief.
]
|===
Expand Down Expand Up @@ -237,8 +243,10 @@ enum E3 : char;
[,cols=2]
|===
|Name |Description
|xref:E3-e6[`pass:v[e6]`] |
|xref:E3-e7[`pass:v[e7]`] |
|`e6`
|
|`e7`
|
|===

[#E3-e6]
Expand Down
16 changes: 8 additions & 8 deletions test-files/golden-tests/enum.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ <h3>Members</h3>
</thead>
<tbody>
<tr>
<td><a href="#E0-e0">e0</a></td>
<td>e0</td>
<td><p><span>e0 brief.</span></p>

</td>
</tr>
<tr>
<td><a href="#E0-e1">e1</a></td>
<td>e1</td>
<td><p><span>e1 brief.</span></p>

</td>
Expand Down Expand Up @@ -167,11 +167,11 @@ <h3>Members</h3>
</thead>
<tbody>
<tr>
<td><a href="#E1-e2">e2</a></td>
<td>e2</td>
<td></td>
</tr>
<tr>
<td><a href="#E1-e3">e3</a></td>
<td>e3</td>
<td></td>
</tr>
</tbody>
Expand Down Expand Up @@ -239,13 +239,13 @@ <h3>Members</h3>
</thead>
<tbody>
<tr>
<td><a href="#E2-e4">e4</a></td>
<td>e4</td>
<td><p><span>e4 brief.</span></p>

</td>
</tr>
<tr>
<td><a href="#E2-e5">e5</a></td>
<td>e5</td>
<td><p><span>e5 brief.</span></p>

</td>
Expand Down Expand Up @@ -342,11 +342,11 @@ <h3>Members</h3>
</thead>
<tbody>
<tr>
<td><a href="#E3-e6">e6</a></td>
<td>e6</td>
<td></td>
</tr>
<tr>
<td><a href="#E3-e7">e7</a></td>
<td>e7</td>
<td></td>
</tr>
</tbody>
Expand Down
Loading