polymorphic info members use value semantics #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An automated preview of the documentation is available at https://820.mrdocs.prtest2.cppalliance.org/index.html |
alandefreitas
force-pushed
the
hbs-gen-sync
branch
2 times, most recently
from
322a59d to
d2f1960
Compare
|
An automated preview of the documentation is available at https://820.mrdocs.prtest2.cppalliance.org/index.html |
alandefreitas
force-pushed
the
hbs-gen-sync
branch
2 times, most recently
from
9feec55 to
564d0d4
Compare
|
An automated preview of the documentation is available at https://820.mrdocs.prtest2.cppalliance.org/index.html |
Wherever std::unique_ptr was used for polymorphic members of Info objects, the pointer addresses were being used in comparisons instead of the dereferenced values, which only returned true when both were nullptr. #fix
alandefreitas
force-pushed
the
hbs-gen-sync
branch
from
564d0d4 to
06e3179
Compare
|
An automated preview of the documentation is available at https://820.mrdocs.prtest2.cppalliance.org/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wherever std::unique_ptr was used for polymorphic members of Info objects, the pointer addresses were being used in comparisons instead of the dereferenced values, which only returned true when both were nullptr and led to arbitrary results.
#fix